Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved user exists error to email field on Signup page #183

Merged
merged 3 commits into from
Sep 9, 2024
Merged

Moved user exists error to email field on Signup page #183

merged 3 commits into from
Sep 9, 2024

Conversation

mr-loop-1
Copy link
Contributor

Fixes #175

  • Currently the backend auth function only checks if user exists, hence corrected the error message in response.
  • moved the error message on frontend to email field

@erenfn erenfn self-requested a review September 5, 2024 12:02
erenfn
erenfn previously approved these changes Sep 5, 2024
View reviewed changes
uparkalau
uparkalau previously requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@uparkalau uparkalau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have to adjust the tests on frontend as well

@erenfn erenfn dismissed uparkalau’s stale review September 9, 2024 00:13

tests on frontend are adjusted

@erenfn erenfn merged commit d73f9b2 into bluewave-labs:develop Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erenfn erenfn erenfn approved these changes

@uparkalau uparkalau Awaiting requested review from uparkalau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mr-loop-1 @erenfn @uparkalau