Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 176 sidebar height #190

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

Cihatata
Copy link
Contributor

@Cihatata Cihatata commented Sep 8, 2024

No description provided.

erenfn
erenfn previously approved these changes Sep 9, 2024
@gorkem-bwl
Copy link
Contributor

Thanks Cihat!

@erenfn erenfn requested review from uparkalau and erenfn September 9, 2024 12:54
@erenfn erenfn dismissed their stale review September 9, 2024 13:10

Other scenes are also affected by this change

@erenfn
Copy link
Collaborator

erenfn commented Sep 9, 2024

Do you think this is the most optimal way to do this? If yes, it is ready to merge after you change max-width to width in .login-container in scenes/login/Login.css

@Cihatata
Copy link
Contributor Author

Do you think this is the most optimal way to do this? If yes, it is ready to merge after you change max-width to width in .login-container in scenes/login/Login.css

Fixed @erenfn

@erenfn erenfn merged commit 4d23618 into bluewave-labs:develop Sep 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants