[WIP] Investigating/fixing capsysbin #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
commented
Mar 8, 2020
src/_pytest/capture.py
Outdated
| # Would be good to ensure out and err are of the same type. | ||
| class CaptureResult(NamedTuple): | ||
| out: Union[str, bytes] | ||
| err: Union[str, bytes] |
There was a problem hiding this comment.
@bluetech
Can this be done with Generic[AnyStr] to couple types of out/err?
As far as I know `pre-commit` does not have a switch to skip/exclude a "hook", and it should not cause CI to fail - flake8 is enough for this. Ref: pytest-dev#6877
bluetech
reviewed
Mar 9, 2020
| @@ -439,7 +440,11 @@ def __getattr__(self, name): | |||
| return getattr(object.__getattribute__(self, "buffer"), name) | |||
|
|
|||
|
|
|||
| CaptureResult = collections.namedtuple("CaptureResult", ["out", "err"]) | |||
| # XXX: Generic[AnyStr], and AnyStr as type directly does not work? | |||
There was a problem hiding this comment.
Seems like mypy doesn't support generic namedtuples yet: python/mypy#685
|
Fix in 9e5a830, typing not feasible (yet). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: pytest-dev#6871