Don't use public linkage in wallet

- Need to dig further into linkage to discern why DSO linking error only happens with OpenSSL & mnemomics libraries
blur-network · Jun 26, 2020 · 6a849da · 6a849da
1 parent 9a4f0e8
commit 6a849da
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 5 deletions.
diff --git a/src/mnemonics/CMakeLists.txt b/src/mnemonics/CMakeLists.txt
@@ -59,7 +59,6 @@ target_link_libraries(mnemonics
   PUBLIC
     epee
     easylogging
-    ${OPENSSL_LIBRARIES}
     ${Boost_SYSTEM_LIBRARY}
   PRIVATE
     ${EXTRA_LIBRARIES})
diff --git a/src/simplewallet/CMakeLists.txt b/src/simplewallet/CMakeLists.txt
@@ -58,6 +58,7 @@ target_link_libraries(simplewallet
     ${Boost_THREAD_LIBRARY}
     ${CMAKE_THREAD_LIBS_INIT}
     ${GNU_READLINE_LIBRARY}
+    ${OPENSSL_LIBRARIES}
     ${EXTRA_LIBRARIES})
 set_property(TARGET simplewallet
   PROPERTY

diff --git a/src/wallet/CMakeLists.txt b/src/wallet/CMakeLists.txt
@@ -64,7 +64,6 @@ target_link_libraries(wallet
     ${Boost_SERIALIZATION_LIBRARY}
     ${Boost_FILESYSTEM_LIBRARY}
     ${Boost_SYSTEM_LIBRARY}
-    ${OPENSSL_LIBRARIES}
     ${Boost_THREAD_LIBRARY}
     ${Boost_REGEX_LIBRARY}
     ${EXTRA_LIBRARIES})
@@ -99,7 +98,6 @@ target_link_libraries(wallet_rpc_server
     ${Boost_FILESYSTEM_LIBRARY}
     ${Boost_THREAD_LIBRARY}
     ${CMAKE_THREAD_LIBS_INIT}
-    ${OPENSSL_LIBRARIES}
     ${EXTRA_LIBRARIES})
 set_property(TARGET wallet_rpc_server
   PROPERTY

diff --git a/src/wallet/api/CMakeLists.txt b/src/wallet/api/CMakeLists.txt
@@ -64,7 +64,7 @@ monero_add_library(wallet_api
   ${wallet_api_headers}
   ${wallet_api_private_headers})
 target_link_libraries(wallet_api
-  PUBLIC
+  PRIVATE
     wallet
     common
     cryptonote_core
@@ -76,7 +76,6 @@ target_link_libraries(wallet_api
     ${Boost_SYSTEM_LIBRARY}
     ${Boost_THREAD_LIBRARY}
     ${Boost_REGEX_LIBRARY}
-  PRIVATE
     ${EXTRA_LIBRARIES})
 
 set_property(TARGET wallet_api PROPERTY EXCLUDE_FROM_ALL TRUE)