Use stable MaybeUninit when we can (feature detected) #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Also remove the size check since we can't rely on it, even if we want to ensure it has no overhead for the bytes case.)
This was referenced Jul 10, 2019
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up on #114, now that we have stable MaybeUninit, expand the scope of the feature detection to use it on stable when we can.
This is for the 0.4 branch of arrayvec, which is the current release (0.5 / 1.0 pending), so that we reach the largest number of users with the improvement.
Closes #105 (caveat, for Rust 1.36 or later users)