-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize crate #9
Conversation
… -W clippy::pedantic -W clippy::nursery
That sounds nice. Are you interested in becoming a maintainer for the crate? |
Sure! |
This crate hasn't gotten any love in a long time, unfortunately. Maybe a bump to 0.3 is appropriate with all the updates (?) I unfortunately haven't had the bandwidth for all the crates I created long time ago (:sweat_smile:). The risk is that I'd like to give the crate away, but maybe it's best to share maintainership? |
Done!
I'm glad to contribute! Maybe we could discuss what to do with #8 and #10 after this PR? |
Ok so #8 is harder than I thought. Is it Ok if I merge this? |
@schneiderfelipe yes, thanks for doing this. In general feel free to do what you think is best as maintainer, better to be bold than do nothing. |
Hi @bluss, here I propose some small changes:
No version has been bumped.
I haven't observed any significant performance changes.
Now (adadf78):
Before (afdb943):
With those changes, the MSRV becomes 1.56.1.