Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize crate #9

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Modernize crate #9

merged 10 commits into from
Mar 7, 2024

Conversation

schneiderfelipe
Copy link
Collaborator

Hi @bluss, here I propose some small changes:

  • apply rustfmt
  • solve all clippy warnings
  • add a .gitignore
  • migrate to the 2021 edition
  • convert the README file to Markdown

No version has been bumped.

I haven't observed any significant performance changes.

Now (adadf78):

test heap_iterative_7      ... bench:      17,639 ns/iter (+/- 376)
test heap_iterative_7_iter ... bench:      16,231 ns/iter (+/- 558)
test heap_recursive_7      ... bench:       7,119 ns/iter (+/- 558)

Before (afdb943):

test heap_iterative_7      ... bench:      17,629 ns/iter (+/- 500)
test heap_iterative_7_iter ... bench:      16,313 ns/iter (+/- 495)
test heap_recursive_7      ... bench:       7,062 ns/iter (+/- 311)
With those changes, the MSRV becomes 1.56.1.
$ cargo msrv
Fetching index
Determining the Minimum Supported Rust Version (MSRV) for toolchain x86_64-unknown-linux-gnu
Using check command cargo check
Check for toolchain '1.66.1-x86_64-unknown-linux-gnu' succeeded
Check for toolchain '1.61.0-x86_64-unknown-linux-gnu' succeeded
Check for toolchain '1.58.1-x86_64-unknown-linux-gnu' succeeded
Check for toolchain '1.57.0-x86_64-unknown-linux-gnu' succeeded
Check for toolchain '1.56.1-x86_64-unknown-linux-gnu' succeeded
   Finished The MSRV is: 1.56.1   ███████████████████████████████████████████████████████████████████ 00:00:02

@bluss
Copy link
Owner

bluss commented Mar 2, 2024

That sounds nice. Are you interested in becoming a maintainer for the crate?

@schneiderfelipe
Copy link
Collaborator Author

That sounds nice. Are you interested in becoming a maintainer for the crate?

Sure!

@bluss
Copy link
Owner

bluss commented Mar 2, 2024

This crate hasn't gotten any love in a long time, unfortunately. Maybe a bump to 0.3 is appropriate with all the updates (?)

I unfortunately haven't had the bandwidth for all the crates I created long time ago (:sweat_smile:). The risk is that I'd like to give the crate away, but maybe it's best to share maintainership?

@schneiderfelipe
Copy link
Collaborator Author

schneiderfelipe commented Mar 5, 2024

This crate hasn't gotten any love in a long time, unfortunately. Maybe a bump to 0.3 is appropriate with all the updates (?)

Done!

I unfortunately haven't had the bandwidth for all the crates I created long time ago (:sweat_smile:). The risk is that I'd like to give the crate away, but maybe it's best to share maintainership?

I'm glad to contribute! Maybe we could discuss what to do with #8 and #10 after this PR?

@bluss
Copy link
Owner

bluss commented Mar 7, 2024

#8 unsure if it has a realistic solution. Maybe a separate HeapOwned type? The reporter of #8 does not have an explanation for how the iterator would work (?) It would need to copy, not borrow the current iteration's array.

@schneiderfelipe
Copy link
Collaborator Author

Ok so #8 is harder than I thought.

Is it Ok if I merge this?

@bluss
Copy link
Owner

bluss commented Mar 7, 2024

@schneiderfelipe yes, thanks for doing this. In general feel free to do what you think is best as maintainer, better to be bold than do nothing.

@schneiderfelipe schneiderfelipe merged commit 5d993c3 into bluss:master Mar 7, 2024
@schneiderfelipe schneiderfelipe deleted the modernize branch March 7, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants