-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Implement sidebar component #83
Conversation
Reviewer's Guide by SourceryThis PR introduces a new sidebar component implementation with various customization options and subcomponents. The changes include a new variant class helper function and a comprehensive sidebar module with multiple rendering options and styling configurations. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bluzky - I've reviewed your changes - here's some feedback:
Overall Comments:
- The
assigns
function appears to be missing its name and implementation - should this besidebar_footer
? - The new file is named 'slidebar.ex' but should be 'sidebar.ex' to match the module name
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add a new sidebar component with customizable attributes and a function for building variant classes to enhance UI flexibility.
New Features:
Enhancements: