Ensure millisecond precision in read_response() #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The micropython documentation for utime.time() states that on some hardware, the function only have second precision. This is the case at least for the TinyPICO board. This means that we get an effective 1 second timeout for the read_response() function instead of the expected 50ms. In turn, it makes the run() function quite slow which delays the whole application. To get higher precision, the documentation recommends to use utime.ticks_ms() instead which is what have been implemented here.
antohaUa
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The micropython documentation for utime.time() states that on
some hardware, the function only have second precision.
This is the case at least for the TinyPICO board.
This means that we get an effective 1 second timeout for the
read_response() function instead of the expected 50ms. In turn,
it makes the run() function quite slow which delays the whole
application.
To get higher precision, the documentation recommends to use
utime.ticks_ms() instead which is what have been implemented
here.