[#24] [iOS] [Integrate] As a user, I can log out, Part: ViewModel #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧛 shared Code Coverage:
|
| File | Coverage |
|---|---|
AccountViewModel.kt |
92.78% |
Modified Files Not Found In Coverage Report:
AccountScreen.swift
AccountSpec.swift
AccountView+DataSource.swift
AccountView.swift
AccountViewDataSourceSpec.swift
AccountViewModelTest.kt
AppCoordinator.swift
KMPNative+Guaranteed.swift
ResetPassword+DataSource.swift
RouteCoordinator.swift
Shared+AutoMockable.swift
SplashView+DataSource.swift
SurveySelectionContainerView.swift
SurveySelectionView+DataSource.swift
UseCaseModule.kt
ViewModelModule.kt
project.pbxproj
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
from
67b51d3 to
608580d
Compare
Current coverage for Survey is
|
| Files changed | - | - |
|---|---|---|
| KMPNative+Guaranteed.swift | 70.00% |
|
| RouteCoordinator.swift | 72.73% |
|
| SurveySelectionView+DataSource.swift | 87.10% |
✅ |
| ResetPassword+DataSource.swift | 87.50% |
✅ |
| SurveySelectionContainerView.swift | 91.15% |
✅ |
| SplashView+DataSource.swift | 91.49% |
✅ |
| AccountView+DataSource.swift | 100.00% |
✅ |
| AccountView.swift | 100.00% |
✅ |
| AppCoordinator.swift | 100.00% |
✅ |
Powered by xcov
Generated by 🚫 Danger
blyscuit
changed the title
blyscuit
force-pushed
the
feature/#25-logout-backend
branch
from
80e57c0 to
950c0a5
Compare
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
3 times, most recently
from
448cb73 to
892d17e
Compare
blyscuit
force-pushed
the
feature/#25-logout-backend
branch
3 times, most recently
from
c25a8a5 to
c9d23e2
Compare
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
from
892d17e to
18e67c9
Compare
blyscuit
commented
Jan 4, 2023
...ommonTest/kotlin/co/nimblehq/blisskmmic/presentation/modules/account/AccountViewModelTest.kt
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
from
18e67c9 to
fc60eba
Compare
blyscuit
requested review from
suho,
edgarss,
minhnimble and
doannimble
as code owners
suho
reviewed
Jan 5, 2023
...Survey/Sources/Presentation/Modules/SurveySelection/AccountView/AccountView+DataSource.swift
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
from
c8ce2ab to
481343a
Compare
minhnimble
reviewed
Jan 5, 2023
...s/Sources/Specs/Presentation/Modules/SurveySelection/Account/AccountViewDataSourceSpec.swift
Outdated
Show resolved
Hide resolved
...s/Sources/Specs/Presentation/Modules/SurveySelection/Account/AccountViewDataSourceSpec.swift
Outdated
Show resolved
Hide resolved
...s/Sources/Specs/Presentation/Modules/SurveySelection/Account/AccountViewDataSourceSpec.swift
Show resolved
Hide resolved
iosApp/Survey/Sources/Presentation/Coordinator/RouteCoordinator.swift
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
from
9a9e692 to
64f8c3d
Compare
doannimble
reviewed
Jan 5, 2023
shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/di/koin/modules/ViewModelModule.kt
Show resolved
Hide resolved
...Survey/Sources/Presentation/Modules/SurveySelection/AccountView/AccountView+DataSource.swift
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
from
48cbf91 to
9adb660
Compare
edgarss
approved these changes
Jan 6, 2023
minhnimble
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
User can logout from the side bar.
Insight
AccountViewModel.AccountViewDataSource.guaranteedPublisherto return KMM ViewState as a Publisher with fallback.Proof Of Work
Screen.Recording.2022-12-22.at.16.41.09.mp4