[#19] [Integrate] As a user, I can see Survey selection page #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧛 shared Code Coverage:
|
| File | Coverage |
|---|---|
SurveySelectionViewModel.kt |
96.77% |
SurveyUiModel.kt |
78.05% |
Modified Files Not Found In Coverage Report:
FadePaginationView.swift
LoginScreen.swift
Shared+AutoMockable.swift
Survey Staging Extended Tests.xcscheme
SurveyScreen.swift
SurveySelectionSpec.swift
SurveySelectionView+DataSource.swift
SurveySelectionView.swift
SurveySelectionViewDataSourceSpec.swift
SurveySelectionViewModelTest.kt
project.pbxproj
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
blyscuit
force-pushed
the
feature/#19-survey-selection-integration
branch
2 times, most recently
from
d67c5d3 to
a966163
Compare
blyscuit
changed the title
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
2 times, most recently
from
dda8d54 to
448cb73
Compare
blyscuit
force-pushed
the
feature/#19-survey-selection-integration
branch
from
a966163 to
1809a3e
Compare
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
3 times, most recently
from
18e67c9 to
fc60eba
Compare
blyscuit
force-pushed
the
feature/#19-survey-selection-integration
branch
from
1809a3e to
7e8640e
Compare
blyscuit
force-pushed
the
feature/#24-logout-integration
branch
from
48cbf91 to
9adb660
Compare
blyscuit
force-pushed
the
feature/#19-survey-selection-integration
branch
2 times, most recently
from
54db60f to
2fc5af9
Compare
blyscuit
requested review from
suho,
edgarss,
minhnimble and
doannimble
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
blyscuit
changed the title
doannimble
reviewed
Jan 10, 2023
...tlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt
Outdated
Show resolved
Hide resolved
...tlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#19-survey-selection-integration
branch
from
2fc5af9 to
d664cdc
Compare
minhnimble
reviewed
Jan 10, 2023
iosApp/Survey/Sources/Supports/Helpers/KMM/AutoMockable/Shared+AutoMockable.swift
Show resolved
Hide resolved
...tlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt
Show resolved
Hide resolved
suho
approved these changes
Jan 10, 2023
minhnimble
approved these changes
Jan 12, 2023
minhnimble
reviewed
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Describe the big picture of your changes here to communicate to the team why we should accept this pull request.
Insight
Describe in details how to test the changes; referenced documentation is welcome as well.
Proof Of Work
Screen.Recording.2022-12-28.at.16.09.36.mp4