[#24] [iOS] [Integrate] As a user, I can log out #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blyscuit
requested review from
suho,
edgarss,
minhnimble and
doannimble
as code owners
blyscuit
force-pushed
the
feature/#24-logout-ui-integration
branch
from
f61a282 to
f16de65
Compare
🧛 shared Code Coverage:
|
| File | Coverage |
|---|---|
AccountUiModel.kt |
100.00% |
AppInfoRepositoryImpl.kt |
100.00% |
AppVersion.kt |
100.00% |
GetAppVersionUseCase.kt |
100.00% |
Platform.kt |
100.00% |
SurveySelectionViewModel.kt |
100.00% |
Modified Files Not Found In Coverage Report:
AccountView.swift
AppInfoRepository.kt
AppInfoRepositoryTest.kt
DomainHelperModule.kt
GetAppVersionUseCaseTest.kt
RepositoryModule.kt
Shared+AutoMockable.swift
SurveySelectionContainerView.swift
SurveySelectionView.swift
SurveySelectionViewDataSourceSpec.swift
SurveySelectionViewModelTest.kt
UseCaseModule.kt
VersionCode.kt
VersionCodeImpl.kt
VersionCodeImpl.kt
strings.xml
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
minhnimble
reviewed
Jan 4, 2023
iosApp/Survey/Sources/Presentation/Modules/SurveySelection/SurveySelectionContainerView.swift
Show resolved
Hide resolved
shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/domain/platform/VersionCode.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/domain/platform/VersionCode.kt
Show resolved
Hide resolved
shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/domain/platform/VersionCode.kt
Outdated
Show resolved
Hide resolved
shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/domain/repository/AppInfoRepository.kt
Outdated
Show resolved
Hide resolved
shared/src/commonTest/kotlin/co/nimblehq/blisskmmic/data/repository/AppInfoRepositoryTest.kt
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#24-logout-ui-integration
branch
from
f16de65 to
c7fe2ba
Compare
blyscuit
force-pushed
the
feature/#24-logout-ui-integration
branch
from
c7fe2ba to
0507a89
Compare
doannimble
reviewed
Jan 4, 2023
shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/model/AccountUiModel.kt
Outdated
Show resolved
Hide resolved
suho
approved these changes
Jan 5, 2023
minhnimble
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Add UI model for Logout screen.
Insight
VersionCodefor platform version and build number.AppInfoRepositoryfor getting data fromVersionCode.GetAppVersionUseCase.Proof Of Work