Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#26] [iOS] [UI] As a user, I can see Survey Detail - Question #109

Merged
merged 4 commits into from
Jan 31, 2023
Merged

[#26] [iOS] [UI] As a user, I can see Survey Detail - Question #109

merged 4 commits into from
Jan 31, 2023

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Jan 11, 2023 •
edited
Loading

What happened

Add survey detail question UI.

Insight

  • Wrap SurveyDetailView for both Survey Detail and Survey Question.
  • Add animation from Survey detail to Survey detail question.

Proof Of Work

Screen.Recording.2023-01-11.at.12.08.17.mp4

@blyscuit blyscuit added this to the 0.6.0 milestone Jan 11, 2023
@blyscuit blyscuit self-assigned this Jan 11, 2023
@github-actions
Copy link

github-actions bot commented Jan 11, 2023 •
edited
Loading

3 Warnings
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/data/network/core/TokenizedNetworkClient.kt#L47 - The function bearerConfig is too long (21). The maximum length is 20.
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt#L31 - The constructor(getCurrentDateUseCase: GetCurrentDateUseCase, getProfileUseCase: GetProfileUseCase, getAppVersionUseCase: GetAppVersionUseCase, surveyListUseCase: SurveyListUseCase, dateTimeFormatter: DateTimeFormatter) has too many parameters. The current threshold is set to 5.
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt#L31 - Class 'SurveySelectionViewModel' with '13' functions detected. Defined threshold inside classes is set to '10'

🧛 shared Code Coverage: 82.70%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

CGFloat+Extensions.swift
Close Icon.pdf
Contents.json
Double+AnimationDuration.swift
Font+Extensions.swift
SurveyDetailScreen.swift
SurveyDetailView.swift
SurveyQuestionScreen.swift
SurveyQuestionSpec.swift
SurveyQuestionView.swift
SurveySelectionViewModelTest.kt
ViewId+SurveyQuestion.swift
ViewId.swift
project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Jan 11, 2023 •
edited
Loading

Current coverage for Survey is 89.38%

Files changed - -
Double+AnimationDuration.swift 80.00% ✅
SurveyDetailView.swift 98.85% ✅
Font+Extensions.swift 100.00% ✅
ViewId.swift 100.00% ✅
SurveyQuestionView.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit changed the title Feature/#26 UI survey detail question [#26] [UI] As a user, I can see Survey Detail Jan 16, 2023
@blyscuit blyscuit changed the title [#26] [UI] As a user, I can see Survey Detail [#26] [iOS] [UI] As a user, I can see Survey Detail Jan 16, 2023
@blyscuit blyscuit changed the title [#26] [iOS] [UI] As a user, I can see Survey Detail [#26] [iOS] [UI] As a user, I can see Survey Detail - Question Jan 16, 2023
@blyscuit blyscuit force-pushed the feature/#26-ui-survey-detail branch 2 times, most recently from c1cc51b to 43bc346 Compare January 17, 2023 09:09
@blyscuit blyscuit force-pushed the feature/#26-ui-survey-detail-question branch 3 times, most recently from 0ea8ee8 to 2c04c5f Compare January 17, 2023 10:42
@blyscuit blyscuit marked this pull request as ready for review January 18, 2023 02:22
doannimble
doannimble approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blyscuit blyscuit requested a review from minhnimble January 30, 2023 08:37
@blyscuit blyscuit force-pushed the feature/#26-ui-survey-detail-question branch from 84d8636 to 8fa6e84 Compare January 30, 2023 09:47
@blyscuit blyscuit force-pushed the feature/#26-ui-survey-detail branch from b13876b to c217944 Compare January 30, 2023 09:50
@blyscuit blyscuit force-pushed the feature/#26-ui-survey-detail-question branch from 8fa6e84 to b11c7cf Compare January 30, 2023 09:51
@blyscuit blyscuit force-pushed the feature/#26-ui-survey-detail branch from c217944 to 9483b8c Compare January 30, 2023 11:28
@blyscuit blyscuit force-pushed the feature/#26-ui-survey-detail-question branch from b11c7cf to 7444c09 Compare January 30, 2023 11:29
suho
suho approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@suho suho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! With KIF, the UITests looks neat

Base automatically changed from feature/#26-ui-survey-detail to develop January 31, 2023 11:21
@blyscuit blyscuit force-pushed the feature/#26-ui-survey-detail-question branch from 7444c09 to 15d3019 Compare January 31, 2023 11:35
@blyscuit blyscuit merged commit d5c6f56 into develop Jan 31, 2023
@blyscuit blyscuit deleted the feature/#26-ui-survey-detail-question branch January 31, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doannimble doannimble doannimble approved these changes

@minhnimble minhnimble minhnimble approved these changes

@suho suho suho approved these changes

@edgarss edgarss edgarss approved these changes

Assignees

@blyscuit blyscuit

Labels
platform: Swift type: feature
Projects
KMM IC
Status: Done
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@blyscuit @edgarss @suho @minhnimble @doannimble