Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#40] [iOS] [UI] As a user, I can submit my form #123

Merged
merged 1 commit into from
Feb 27, 2023
Merged

[#40] [iOS] [UI] As a user, I can submit my form #123

merged 1 commit into from
Feb 27, 2023

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Feb 3, 2023 •
edited
Loading

What happened

Add Submit button and loading screen.

Insight

  • Clicking on the submit button with freeze the app in the loading state for the moment.

Proof Of Work

Screen.Recording.2023-02-03.at.18.08.49.mov

@blyscuit blyscuit changed the title [#40] Add submit button and loading [#40] [iOS] [UI] As a user, I can submit my form Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 3, 2023 •
edited
Loading

4 Warnings
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/data/network/core/TokenizedNetworkClient.kt#L47 - The function bearerConfig is too long (21). The maximum length is 20.
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt#L31 - The constructor(getCurrentDateUseCase: GetCurrentDateUseCase, getProfileUseCase: GetProfileUseCase, getAppVersionUseCase: GetAppVersionUseCase, surveyListUseCase: SurveyListUseCase, dateTimeFormatter: DateTimeFormatter) has too many parameters. The current threshold is set to 5.
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt#L31 - Class 'SurveySelectionViewModel' with '13' functions detected. Defined threshold inside classes is set to '10'

🧛 shared Code Coverage: 78.67%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

SurveyDetailView.swift
ViewId+SurveyDetail.swift
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@blyscuit blyscuit self-assigned this Feb 3, 2023
@blyscuit blyscuit added this to the 0.8.0 milestone Feb 3, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023 •
edited
Loading

Current coverage for Survey is 73.49%

Files changed - -
SurveyDetailView.swift 87.96% ✅

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit force-pushed the feature/#35-survey-quit-prompt-ui branch 4 times, most recently from 87ee2df to f4f7beb Compare February 9, 2023 02:14
@blyscuit blyscuit force-pushed the feature/#35-survey-quit-prompt-ui branch from f4f7beb to 3c7bfc0 Compare February 15, 2023 09:02
@blyscuit blyscuit force-pushed the feature/#40-submit-ui branch from 45891a9 to 9a34a0d Compare February 16, 2023 04:14
Base automatically changed from feature/#35-survey-quit-prompt-ui to develop February 16, 2023 04:24
@blyscuit blyscuit changed the base branch from develop to chore/bump-version-0.8.0 February 22, 2023 02:21
@blyscuit blyscuit force-pushed the feature/#40-submit-ui branch from 9a34a0d to 998cc2b Compare February 22, 2023 02:21
@blyscuit blyscuit marked this pull request as ready for review February 22, 2023 02:21
Base automatically changed from chore/bump-version-0.8.0 to develop February 22, 2023 02:56
edgarss
edgarss approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@edgarss edgarss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blyscuit blyscuit requested a review from minhnimble February 23, 2023 09:40
@blyscuit blyscuit merged commit ea59631 into develop Feb 27, 2023
@blyscuit blyscuit deleted the feature/#40-submit-ui branch February 27, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doannimble doannimble doannimble approved these changes

@minhnimble minhnimble minhnimble approved these changes

@suho suho suho approved these changes

@edgarss edgarss edgarss approved these changes

Assignees

@blyscuit blyscuit

Labels
platform: Swift type: feature
Projects
KMM IC
Status: Done
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@blyscuit @edgarss @suho @minhnimble @doannimble