Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 0.7.0 #129

Merged
merged 20 commits into from
Feb 22, 2023
Merged

Release - 0.7.0 #129

merged 20 commits into from
Feb 22, 2023

Conversation

blyscuit and others added 20 commits February 6, 2023 16:39
[#30] [iOS] [UI] As a user, I can see Survey Detail emoji form
[#31] [iOS] [UI] As a user, I can see Survey Detail range picker
[#32] [iOS] [UI] As a user, I can see Survey Detail multi selection picker
[#33] [iOS] [UI] As a user, I can see Survey Detail multi form
[#34] [iOS] [UI] As a user, I can see Survey Detail single form
[#35] [#36] [iOS] [UI] As a user, I can see survey quit prompt
@blyscuit blyscuit self-assigned this Feb 16, 2023
@blyscuit blyscuit added this to the 0.7.0 milestone Feb 16, 2023
@blyscuit blyscuit marked this pull request as ready for review February 16, 2023 04:35
Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@github-actions
Copy link

7 Warnings
⚠️ Uh oh! SurveyDetail.kt is under 95% coverage!
⚠️ Uh oh! SurveyDetailApiModel.kt is under 95% coverage!
⚠️ Uh oh! SurveyDetailUiModel.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/data/network/core/TokenizedNetworkClient.kt#L47 - The function bearerConfig is too long (21). The maximum length is 20.
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt#L31 - The constructor(getCurrentDateUseCase: GetCurrentDateUseCase, getProfileUseCase: GetProfileUseCase, getAppVersionUseCase: GetAppVersionUseCase, surveyListUseCase: SurveyListUseCase, dateTimeFormatter: DateTimeFormatter) has too many parameters. The current threshold is set to 5.
⚠️ shared/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModel.kt#L31 - Class 'SurveySelectionViewModel' with '13' functions detected. Defined threshold inside classes is set to '10'

🧛 shared Code Coverage: 78.67%

Coverage of Modified Files:

File Coverage
SurveyDetail.kt 33.33%
SurveyDetailApiModel.kt 69.83%
SurveyDetailUiModel.kt 22.26%

Modified Files Not Found In Coverage Report:

CGFloat+Extensions.swift
Constants+SystemImage.swift
Font+Extensions.swift
QuestionEmojiView.swift
QuestionMultiChoiceView.swift
QuestionMultiFormView.swift
QuestionPickerView.swift
QuestionRangePickerView.swift
QuestionTextAreaView.swift
RouteCoordinator.swift
SurveyDetailView.swift
SurveyQuestionScreen.swift
SurveyQuestionSpec.swift
SurveyQuestionView.swift
project.pbxproj
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

Current coverage for Survey is 74.08%

Files changed - -
QuestionMultiFormView.swift 0.00% 💀
QuestionEmojiView.swift 0.00% 💀
QuestionMultiChoiceView.swift 0.00% 💀
QuestionRangePickerView.swift 0.00% 💀
QuestionPickerView.swift 0.00% 💀
QuestionTextAreaView.swift 0.00% 💀
SurveyQuestionView.swift 77.42% ⚠️
RouteCoordinator.swift 80.95%
SurveyDetailView.swift 94.60%
Font+Extensions.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit merged commit 74fec55 into main Feb 22, 2023
@blyscuit blyscuit deleted the release/0.7.0 branch February 22, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants