[#41] [Integrate] As a user, I can submit my form #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage for Survey is
|
| Files changed | - | - |
|---|---|---|
| QuestionRangePickerView.swift | 0.00% |
💀 |
| QuestionMultiChoiceView.swift | 0.00% |
💀 |
| SurveyQuestionView.swift | 0.00% |
💀 |
| QuestionMultiFormView.swift | 0.00% |
💀 |
| QuestionTextAreaView.swift | 0.00% |
💀 |
| QuestionEmojiView.swift | 0.00% |
💀 |
| QuestionPickerView.swift | 0.00% |
💀 |
| SurveyDetailView.swift | 61.73% |
|
| SurveyDetailView+DataSource.swift | 66.67% |
Powered by xcov
Generated by 🚫 Danger
🧛 shared Code Coverage:
|
| File | Coverage |
|---|---|
SurveyDetailDummy.kt |
100.00% |
SurveyDetailViewModel.kt |
97.65% |
SurveyQuestionViewState.kt |
100.00% |
SurveySelectionViewModel.kt |
96.83% |
SurveySubmissionUiModel.kt |
100.00% |
Modified Files Not Found In Coverage Report:
QuestionEmojiView.swift
QuestionMultiChoiceView.swift
QuestionMultiFormView.swift
QuestionPickerView.swift
QuestionRangePickerView.swift
QuestionTextAreaView.swift
SurveyDetailView+DataSource.swift
SurveyDetailView.swift
SurveyDetailViewModelTest.kt
SurveyQuestionView.swift
ViewModelModule.kt
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
blyscuit
force-pushed
the
feature/#42-thank-you-screen
branch
2 times, most recently
from
fdb1957 to
394f965
Compare
blyscuit
changed the title
blyscuit
changed the title
blyscuit
force-pushed
the
feature/#41-submit-integration
branch
from
e3f5058 to
db12b91
Compare
blyscuit
force-pushed
the
feature/#42-thank-you-screen
branch
from
658afed to
90c3aff
Compare
blyscuit
force-pushed
the
feature/#41-submit-integration
branch
from
db12b91 to
005c330
Compare
blyscuit
requested review from
suho,
edgarss,
minhnimble and
doannimble
as code owners
blyscuit
force-pushed
the
feature/#41-submit-integration
branch
from
005c330 to
33ea5b3
Compare
minhnimble
reviewed
Mar 2, 2023
iosApp/Survey/Sources/Presentation/Modules/SurveyDetail/SurveyQuestion/QuestionEmojiView.swift
Outdated
Show resolved
Hide resolved
...ain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveydetail/SurveyDetailViewModel.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveydetail/SurveyDetailViewModel.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveydetail/SurveyDetailViewModel.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveydetail/SurveyDetailViewModel.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveydetail/SurveyDetailViewModel.kt
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#41-submit-integration
branch
from
01878c0 to
abe5f9b
Compare
|
@minhnimble Thank you for the suggestions. Updated to your suggestions. 🙏 |
minhnimble
approved these changes
Mar 7, 2023
...ain/kotlin/co/nimblehq/blisskmmic/presentation/modules/surveydetail/SurveyDetailViewModel.kt
Outdated
Show resolved
Hide resolved
edgarss
approved these changes
Mar 7, 2023
...d/src/commonMain/kotlin/co/nimblehq/blisskmmic/presentation/model/SurveySubmissionUiModel.kt
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#41-submit-integration
branch
from
abe5f9b to
bd8b68e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Integrate form submission.
Insight
SurveyQuestionViewStateforSurveyDetailViewModel.SurveyQuestionViewStatetoSurveyDetailView.SurveyDetailViewtoSurveyDetailViewModel.SurveySubmissionUiModelfor mapping answers from UI to Domain use case.Proof Of Work
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-02-17.at.15.00.48.mp4