Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#3] [#7] [iOS] Set Up CICD for iOS for test and upload to Firebase Distribution #47

Merged
merged 10 commits into from
Sep 21, 2022
Merged

[#3] [#7] [iOS] Set Up CICD for iOS for test and upload to Firebase Distribution #47

merged 10 commits into from
Sep 21, 2022

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Sep 15, 2022 •
edited
Loading

close #3
close #7

What Happened

Add two workflows:

  • Deploy Staging iOS app to Firebase Distribution.
  • Deploy Production iOS app to Firebase Distribution.

Both workflows:

  • Test debug iOS app.
  • Match certificates and profiles from github.com/nimblehq/match-certificates

Insight

  • Modified iOS template to use with KMM.
  • Use Firebase only for fastlane.

Proof of Work

Tested link https://github.com/blyscuit/kmm-swiftUI-IC/actions/runs/3058076997

Screen Shot 2022-09-15 at 13 09 57

@blyscuit blyscuit self-assigned this Sep 15, 2022
@blyscuit blyscuit force-pushed the chore/#7-cicd-firebase-distribution branch from b578bff to 8390314 Compare September 15, 2022 07:31
@github-actions
Copy link

github-actions bot commented Sep 15, 2022 •
edited
Loading

template Jacoco report:

Generated by 🚫 Danger

@blyscuit blyscuit force-pushed the chore/#2-set-up-ios branch 7 times, most recently from 253849e to 7fade68 Compare September 16, 2022 05:29
Base automatically changed from chore/#2-set-up-ios to develop September 16, 2022 08:17
@blyscuit blyscuit force-pushed the chore/#7-cicd-firebase-distribution branch 2 times, most recently from 0ce7775 to 7307217 Compare September 16, 2022 08:46
@github-actions
Copy link

github-actions bot commented Sep 16, 2022 •
edited
Loading

Current coverage for Survey is 82.35%

✅ No files affecting coverage found

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit marked this pull request as ready for review September 16, 2022 09:12
@blyscuit blyscuit force-pushed the chore/#7-cicd-firebase-distribution branch 2 times, most recently from 4c4c183 to 891352a Compare September 19, 2022 06:49
@blyscuit blyscuit force-pushed the chore/#7-cicd-firebase-distribution branch from 891352a to eee882b Compare September 19, 2022 06:50
@blyscuit blyscuit added this to the 0.0.1 milestone Sep 19, 2022
suho
suho approved these changes Sep 19, 2022
View reviewed changes
Copy link
Collaborator

@suho suho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

minhnimble
minhnimble approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor concern, the rest LGTM 🚀

.gitignore Outdated Show resolved Hide resolved
@blyscuit blyscuit merged commit 22b814e into develop Sep 21, 2022
@blyscuit blyscuit deleted the chore/#7-cicd-firebase-distribution branch September 21, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minhnimble minhnimble minhnimble approved these changes

@suho suho suho approved these changes

@edgarss edgarss edgarss approved these changes

Assignees

@blyscuit blyscuit

Labels
platform: Swift type: chore
Projects
KMM IC
Status: Done
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@blyscuit @edgarss @suho @minhnimble