Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#20] [iOS] [UI] As a user, I can see Survey header #60

Merged
merged 5 commits into from
Nov 18, 2022

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Oct 5, 2022

What Happened

Add Survey screen header with today information and user profile

Proof of Work

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

🧛 shared Code Coverage: 69.01%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

CGFloat+Extensions.swift
Font+Extensions.swift
SurveyHeaderView.swift
SurveyItemView.swift
SurveySelectionSpec.swift
SurveySelectionView.swift
ViewId+SurveySelection.swift
project.pbxproj

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Oct 5, 2022

Current coverage for Survey is 72.70%

Files changed - -
SurveySelectionView.swift 96.22%
Font+Extensions.swift 100.00%
SurveyItemView.swift 100.00%
SurveyHeaderView.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit self-assigned this Oct 5, 2022
@blyscuit blyscuit added this to the 0.0.2 milestone Oct 5, 2022
@blyscuit blyscuit force-pushed the feature/#17-ui-survey-selection branch from 400b67a to df43098 Compare October 19, 2022 09:03
@blyscuit blyscuit force-pushed the feature/#20-ui-survey-header branch from 44395ca to 3331209 Compare October 26, 2022 10:46
@blyscuit blyscuit force-pushed the feature/#17-ui-survey-selection branch 2 times, most recently from 61e2aa5 to 9ccca20 Compare October 27, 2022 09:20
@blyscuit blyscuit force-pushed the feature/#20-ui-survey-header branch from 3331209 to 5a84e75 Compare October 27, 2022 09:24
@blyscuit blyscuit force-pushed the feature/#17-ui-survey-selection branch 4 times, most recently from cb1d18c to 3315a2c Compare November 14, 2022 08:11
@blyscuit blyscuit force-pushed the feature/#20-ui-survey-header branch from 5a84e75 to 19f2a57 Compare November 14, 2022 08:38
@blyscuit blyscuit marked this pull request as ready for review November 14, 2022 09:14
Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM 🚀

Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 🚀

Copy link
Collaborator

@suho suho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feature/#17-ui-survey-selection to develop November 18, 2022 09:14
@blyscuit blyscuit force-pushed the feature/#20-ui-survey-header branch from 47afc27 to a4953ed Compare November 18, 2022 10:00
@blyscuit blyscuit merged commit fea80c7 into develop Nov 18, 2022
@blyscuit blyscuit deleted the feature/#20-ui-survey-header branch November 18, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants