Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12] [iOS] [Integrate] [Part1] As a user, I can reset my password #64

Merged
merged 4 commits into from
Dec 6, 2022

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Oct 20, 2022

What Happened

Add Notification capability to iOS app.

Insight

  • Add Notification Centers related protocol for testing.
  • Add ResetPasswordViewModel

Proof of Work

@blyscuit blyscuit added this to the 0.0.3 milestone Oct 20, 2022
@blyscuit blyscuit self-assigned this Oct 20, 2022
@github-actions
Copy link

github-actions bot commented Oct 20, 2022

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

🧛 shared Code Coverage: 73.76%

Coverage of Modified Files:

File Coverage
NotificationUiModel.kt 100.00%
ResetPasswordViewModel.kt 100.00%

Modified Files Not Found In Coverage Report:

AppDelegate.swift
AutoMockable.stencil
IOSApp.swift
KoinApplication.swift
NotificationManager.swift
NotificationManagerSpec.swift
ResetPasswordUseCaseTest.kt
ResetPasswordViewModelTest.kt
Start.kt
ViewModelModule.kt
detekt-config.yml
project.pbxproj
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Oct 20, 2022

Current coverage for Survey is 75.29%

Files changed - -
KoinApplication.swift 0.00% 💀
AppDelegate.swift 57.14% ⚠️
NotificationManager.swift 92.45%
IOSApp.swift 100.00%

Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit force-pushed the feature/#13-reset-password-backend branch 2 times, most recently from 6087027 to 0bba983 Compare November 24, 2022 06:10
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch from 5775aa4 to 1140290 Compare November 24, 2022 07:18
@blyscuit blyscuit force-pushed the feature/#13-reset-password-backend branch from 0bba983 to 645eeea Compare November 24, 2022 07:20
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch 2 times, most recently from f0209f0 to bb354ce Compare November 24, 2022 08:38
@blyscuit blyscuit changed the title [#12] [iOS] [Integrate] As a user, I can reset my password [#12] [iOS] [Integrate] [Part1] As a user, I can reset my password Nov 24, 2022
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch from cc527b5 to 3c5a3da Compare November 25, 2022 03:13
@blyscuit blyscuit force-pushed the feature/#13-reset-password-backend branch 4 times, most recently from 9f0800d to 9bccd8d Compare November 30, 2022 05:03
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch from 87cc557 to a24ebc2 Compare November 30, 2022 07:31
@blyscuit blyscuit force-pushed the feature/#13-reset-password-backend branch from 9bccd8d to bca3d83 Compare November 30, 2022 07:34
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch from a24ebc2 to 0ee065f Compare November 30, 2022 07:37
@blyscuit blyscuit marked this pull request as ready for review November 30, 2022 09:15
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch from 0ee065f to 1efbe45 Compare November 30, 2022 09:17
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch from e126ea2 to 9573379 Compare December 1, 2022 04:50
Base automatically changed from feature/#13-reset-password-backend to develop December 1, 2022 10:41
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch from 3e7956b to 9146e84 Compare December 1, 2022 11:04
@blyscuit blyscuit force-pushed the feature/#12-reset-password-integrate branch from 9146e84 to 4c741ff Compare December 1, 2022 11:52
Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor refactor left, rest LGTM 🚀

Copy link
Collaborator

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🏃‍♂️

@blyscuit blyscuit merged commit 4937767 into develop Dec 6, 2022
@blyscuit blyscuit deleted the feature/#12-reset-password-integrate branch December 6, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants