[#22] [iOS] [Integrate] As a user, I can see Survey header #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
58c0dad to
75bd93c
Compare
🧛 shared Code Coverage:
|
| File | Coverage |
|---|---|
SurveyHeaderUiModel.kt |
100.00% |
SurveySelectionViewModel.kt |
100.00% |
TokenizedNetworkClient.kt |
96.33% |
Modified Files Not Found In Coverage Report:
AppCoordinator.swift
DomainHelperModule.kt
Koin.kt
KoinApplication.swift
LoginSpec.swift
LoginView+DataSource.swift
LoginViewDataSourceSpec.swift
RouteCoordinator.swift
Screen.swift
Shared+AutoMockable.swift
SplashView+DataSource.swift
Start.kt
SurveyHeaderView.swift
SurveyLoading.swift
SurveyLoadingScreen.swift
SurveySelectionSpec.swift
SurveySelectionView+DataSource.swift
SurveySelectionView.swift
SurveySelectionViewDataSourceSpec.swift
SurveySelectionViewModelTest.kt
ViewDidLoadModifier.swift
ViewModelModule.kt
project.pbxproj
Codebase cunningly covered by count Shroud 🧛
Generated by 🚫 Danger
Current coverage for Survey is
|
| Files changed | - | - |
|---|---|---|
| KoinApplication.swift | 33.33% |
🚫 |
| RouteCoordinator.swift | 62.50% |
|
| SurveySelectionView+DataSource.swift | 87.10% |
✅ |
| LoginView+DataSource.swift | 90.24% |
✅ |
| SplashView+DataSource.swift | 91.49% |
✅ |
| SurveySelectionView.swift | 96.73% |
✅ |
| ViewDidLoadModifier.swift | 100.00% |
✅ |
| SurveyHeaderView.swift | 100.00% |
✅ |
| SurveyLoading.swift | 100.00% |
✅ |
| AppCoordinator.swift | 100.00% |
✅ |
Powered by xcov
Generated by 🚫 Danger
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
f29e037 to
243739f
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
75bd93c to
19bf25a
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.../co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModelTest.kt
Outdated
Show resolved
Hide resolved
.../co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModelTest.kt
Outdated
Show resolved
Hide resolved
.../co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModelTest.kt
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
243739f to
293a85d
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
19bf25a to
817ddc3
Compare
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
293a85d to
5a4a3c6
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
817ddc3 to
f2d3be7
Compare
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
5a4a3c6 to
2422f15
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
2 times, most recently
from
c304df9 to
e72b0d1
Compare
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
2422f15 to
620b57c
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
e72b0d1 to
095a4db
Compare
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
620b57c to
071e6af
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
095a4db to
7f0e810
Compare
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
071e6af to
cfa377f
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
4 times, most recently
from
7031696 to
fbebd54
Compare
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
cfa377f to
363fb2d
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
fbebd54 to
f78dfe4
Compare
blyscuit
requested review from
suho,
edgarss,
minhnimble and
doannimble
as code owners
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
2 times, most recently
from
de0f72a to
f691c78
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
2 times, most recently
from
456f719 to
5878ecb
Compare
blyscuit
force-pushed
the
feature/#21-home-header-backend
branch
from
f691c78 to
16ffe7c
Compare
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
5878ecb to
2465f1a
Compare
minhnimble
reviewed
Dec 28, 2022
...s/Sources/Specs/Presentation/Modules/SurveySelection/SurveySelectionViewDataSourceSpec.swift
Show resolved
Hide resolved
.../co/nimblehq/blisskmmic/presentation/modules/surveyselection/SurveySelectionViewModelTest.kt
Outdated
Show resolved
Hide resolved
blyscuit
force-pushed
the
feature/#22-home-header-viewmodel
branch
from
2465f1a to
572ea6e
Compare
@minhnimble I don't think there's an Android code change in this PR? Only on KMM module for ViewModel. They should be no Android code change as I haven't start the Android app yet 🤔 |
Oh you are right, I saw the creation of the |
minhnimble
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Show Survey header with data from API.
Insight
SurveySelectionViewModel./meinSurveySelectionViewModel.SurveySelectionViewModelalways returnSurveyHeaderUiModelregardless of API error.Proof Of Work
Screen.Recording.2022-12-15.at.17.52.01.mov