Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Add Test Plan #97

Merged
merged 8 commits into from
Dec 19, 2022
Merged

Conversation

blyscuit
Copy link
Owner

@blyscuit blyscuit commented Dec 17, 2022

What happened

Add Test plan for CICD to speed up development.

Insight

  • UITest is getting more complicated and becoming fragile on the CICD.
  • Creates a new Scheme Survey Staging Extended Test for running test on local and periodically on CICD.
  • UITests running on CICD will be crucial flows only.
  • Fix Danger.
  • Add new workflow that runs every 2 hours.

Proof Of Work

Test Plan:

Screen Shot 2022-12-19 at 09 16 47

New Test Plan:

Screen Shot 2022-12-17 at 13 09 43

Old no Test Plan:

Screen Shot 2022-12-17 at 13 10 56

@blyscuit blyscuit added this to the 0.4.0 milestone Dec 17, 2022
@blyscuit blyscuit self-assigned this Dec 17, 2022
@github-actions
Copy link

github-actions bot commented Dec 17, 2022

1 Warning
⚠️ Uh oh! Your project is under 80% coverage!

🧛 shared Code Coverage: 77.55%

Coverage of Modified Files:

File Coverage

Modified Files Not Found In Coverage Report:

.swiftlint.yml
CICDTests.xctestplan
Constants.rb
Dangerfile
Fastfile
Survey Staging Extended Tests.xcscheme
Survey Staging.xcscheme
TestManager.rb
contents.xcworkspacedata
ios_sanity_full_test.yml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@github-actions
Copy link

github-actions bot commented Dec 17, 2022

Current coverage for Survey is 81.32%

No files affecting coverage found


Powered by xcov

Generated by 🚫 Danger

@blyscuit blyscuit force-pushed the chore/test-plan branch 5 times, most recently from 865fa96 to 804fed4 Compare December 17, 2022 07:04
@blyscuit blyscuit marked this pull request as ready for review December 17, 2022 08:07
@blyscuit blyscuit force-pushed the feature/#10-integrate-login branch from d710536 to d540889 Compare December 17, 2022 12:08
@blyscuit blyscuit force-pushed the feature/#10-integrate-login branch from d540889 to d403c28 Compare December 17, 2022 12:48
Copy link
Collaborator

@doannimble doannimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@blyscuit blyscuit requested a review from suho December 19, 2022 06:55
@blyscuit blyscuit requested a review from minhnimble December 19, 2022 08:39
Copy link
Collaborator

@minhnimble minhnimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM 🚀

Copy link
Collaborator

@suho suho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blyscuit blyscuit merged commit bd823bc into feature/#10-integrate-login Dec 19, 2022
@blyscuit blyscuit deleted the chore/test-plan branch December 19, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants