Paths added by disassemble_map() may be leaked when the multipath device is freed

[bmarzins]

If multipathd discovers a path in disassemble_maps() that it isn't already tracking (this can happen if the config has been changed to allow the path, but multipathd has not been reloaded since the change), it will add it to the multipath device, but not to the pathvec:

rh-multipath-tools/libmultipath/dmparser.c

Lines 305 to 330 in d2cf050

	if (!pp) {
	pp = alloc_path();
	if (!pp)
	goto out1;
	strlcpy(pp->dev_t, word, BLK_DEV_SIZE);
	strlcpy(pp->dev, devname, FILE_NAME_SIZE);
	if (strlen(mpp->wwid)) {
	strlcpy(pp->wwid, mpp->wwid,
	WWID_SIZE);
	}
	/* Only call this in multipath client mode */
	if (!is_daemon && store_path(pathvec, pp))
	goto out1;
	} else {
	if (!strlen(pp->wwid) &&
	strlen(mpp->wwid))
	strlcpy(pp->wwid, mpp->wwid,
	WWID_SIZE);
	}
	FREE(word);
	if (store_path(pgp->paths, pp))
	goto out;

When the multiapth device is later freed, if free_multipath is called with KEEP_PATHS, the paths will
not get freed, leaking memory.

rh-multipath-tools/libmultipath/structs.c

Lines 242 to 264 in d2cf050

	void
	free_multipath (struct multipath * mpp, enum free_path_mode free_paths)
	{
	if (!mpp)
	return;
	free_multipath_attributes(mpp);
	if (mpp->alias) {
	FREE(mpp->alias);
	mpp->alias = NULL;
	}
	if (mpp->dmi) {
	FREE(mpp->dmi);
	mpp->dmi = NULL;
	}
	free_pathvec(mpp->paths, free_paths);
	free_pgvec(mpp->pg, free_paths);
	FREE_PTR(mpp->mpcontext);
	FREE(mpp);
	}