Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Add Audio support #62

Merged
merged 8 commits into from
May 2, 2023
Merged

Add Audio support #62

merged 8 commits into from
May 2, 2023

Conversation

Bhasfe
Copy link
Contributor

@Bhasfe Bhasfe commented Apr 30, 2023

  • I have been using the package for a project, and I had a case to add an audio file to generated epub. I have basically used the AddVideo functionality to implement AddAudio

@coveralls
Copy link

coveralls commented Apr 30, 2023

Coverage Status

Coverage: 86.799% (+0.2%) from 86.638% when pulling cb555ed on Bhasfe:main into 74b49e5 on bmaupin:main.

@bmaupin
Copy link
Owner

bmaupin commented May 1, 2023

@Bhasfe The code looks great! I only see one thing that should probably be changed; testdata/sample_audio.wav is rather large (17.8 MB). Could you please replace it with a smaller file? Ideally under 1 MB. Thanks!

@Bhasfe
Copy link
Contributor Author

Bhasfe commented May 1, 2023

@Bhasfe The code looks great! I only see one thing that should probably be changed; testdata/sample_audio.wav is rather large (17.8 MB). Could you please replace it with a smaller file? Ideally under 1 MB. Thanks!

Thank's for your kind and fast response. I replace the audio file with a 1.1 mb wav found here:
https://file-examples.com/index.php/sample-audio-files/sample-wav-download

@bmaupin bmaupin merged commit 5d94be3 into bmaupin:main May 2, 2023
@bmaupin
Copy link
Owner

bmaupin commented May 2, 2023

I went ahead and found an even smaller wav file, just to try to keep the repo size to a minimum. I squashed the commits to avoid the larger files being in the commit history and merged your changes.

It's tagged as release v1.1.0.

Thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants