Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a selector to filter out pods #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a selector to filter out pods #1

wants to merge 2 commits into from

Conversation

blacksd
Copy link

@blacksd blacksd commented Feb 6, 2022

Hey - I added a simple --selector/-l to mimick the kubectl behavior and filter out pods based on a label selector.
Plays nice with empty/invalid conditions, should be good enough 😄

bmcustodio
bmcustodio approved these changes Feb 7, 2022
View reviewed changes
Copy link
Owner

@bmcustodio bmcustodio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much!

@blacksd
Copy link
Author

blacksd commented Apr 5, 2022

@bmcustodio do you plan to merge this soon? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmcustodio bmcustodio bmcustodio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blacksd @bmcustodio