Skip to content

Commit

Permalink
crypto: improve GetECGroupBits signature
Browse files Browse the repository at this point in the history
Remove the unused ECPointer argument and rename the function since the
current name is misleading.

PR-URL: nodejs#53364
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
tniessen authored and bmeck committed Jun 22, 2024
1 parent 72eaff9 commit 119fd62
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions src/crypto/crypto_common.cc
Original file line number Diff line number Diff line change
Expand Up @@ -441,10 +441,7 @@ MaybeLocal<Value> GetECPubKey(
nullptr).FromMaybe(Local<Object>());
}

MaybeLocal<Value> GetECGroup(
Environment* env,
const EC_GROUP* group,
const ECPointer& ec) {
MaybeLocal<Value> GetECGroupBits(Environment* env, const EC_GROUP* group) {
if (group == nullptr)
return Undefined(env->isolate());

Expand Down Expand Up @@ -1324,14 +1321,10 @@ MaybeLocal<Object> X509ToObject(
} else if (ec) {
const EC_GROUP* group = EC_KEY_get0_group(ec.get());

if (!Set<Value>(context,
info,
env->bits_string(),
GetECGroup(env, group, ec)) ||
!Set<Value>(context,
info,
env->pubkey_string(),
GetECPubKey(env, group, ec))) {
if (!Set<Value>(
context, info, env->bits_string(), GetECGroupBits(env, group)) ||
!Set<Value>(
context, info, env->pubkey_string(), GetECPubKey(env, group, ec))) {
return MaybeLocal<Object>();
}

Expand Down

0 comments on commit 119fd62

Please sign in to comment.