Modularize regex backend, add fancy-regex support #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bminixhofer
force-pushed
the
fancy-regex-revive
branch
from
df90bcc to
3aca8b2
Compare
drahnr
pushed a commit
to drahnr/nlprule
that referenced
this pull request
Apr 7, 2021
* modularize regex backend * add fancy-regex backend, improve from_java_regex function * fix srx version * add regex-all backend for testing * use regex-syntax to convert from java regexes * support for ignore case flag * test regex-fancy and regex-onig backends in ci * support multiple of the same kind of lookaround in a regex * ignore replacements which are equal to the text to replace * disallow nested quantifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modularizes the regex backend and adds support for fancy-regex. Fixes #18. The solution is very similar to trishume/syntect#270 with an abstraction on top of
fancy-regexandonig-rsplus feature flags to switch between them. To do:regex-test-allfeature flag which enables both backends at the same time and asserts they do the same thing (needed for tests and building the binaries).regex.rs.