Redo fix to ensure notation for config that warns/disables a rule does not wrap to two lines in rules table cell #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rap to separate line (attempt 2)
bmish
force-pushed
the
superscript-break-2
branch
from
69d3c3f
to
5022ea4
Compare
bmish
changed the title
bmish
changed the title
bmish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #201.
The only solution that worked is manually inserting a linebreak ahead of the emoji with superscript that we want to ensure does not end up with a linebreak inside it.
I also did some refactoring to DRY up the code.