Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo fix to ensure notation for config that warns/disables a rule does not wrap to two lines in rules table cell #203

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

bmish
Copy link
Owner

@bmish bmish commented Nov 1, 2022

Redo of #201.

The only solution that worked is manually inserting a linebreak ahead of the emoji with superscript that we want to ensure does not end up with a linebreak inside it.

I also did some refactoring to DRY up the code.

@bmish bmish added the bug Something isn't working label Nov 1, 2022
@bmish bmish changed the title Redo fix to ensure notation for config that warns/disables a rule does not wrap to separate line Redo fix to ensure notation for config that warns/disables a rule does not wrap to separate line in rules table cell Nov 1, 2022
@bmish bmish merged commit 97125af into main Nov 1, 2022
@bmish bmish deleted the superscript-break-2 branch November 1, 2022 18:29
@bmish bmish changed the title Redo fix to ensure notation for config that warns/disables a rule does not wrap to separate line in rules table cell Redo fix to ensure notation for config that warns/disables a rule does not wrap to two line in rules table cell Nov 1, 2022
@bmish bmish changed the title Redo fix to ensure notation for config that warns/disables a rule does not wrap to two line in rules table cell Redo fix to ensure notation for config that warns/disables a rule does not wrap to two lines in rules table cell Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant