Redesign information architecture of rules table columns and rule doc notices for representing rule configs/severities #205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a substantial redesign of how we represent the configs that a rule belongs to in order to better account for the different error/warn/off severities that a config can set a rule to. This completely replaces the previous design of using emoji superscripts to represent different config severity levels which turned out to be too fragile (fixes #204). I consider this a substantial improvement.
In the readme rules list, there is now a separate config column for each severity level present. The rules list legends and rule doc notices are also affected. See the diffs from the snapshots in this PR. I have also manually tested this in a variety of repos.
Benefits:
Notes:
warnings
configs has changed to 🚸 to avoid a conflict with the emoji which represents a config that sets a rule to warn (