Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker node running status should change to pause when job done #2

Merged
merged 1 commit into from
Nov 28, 2018

Conversation

gitlabbin
Copy link
Contributor

 - the worker clientState need to be `pause`

Fix for issue #1

@bmoers ,please review it, if it is right way to fix.

@bmoers
Copy link
Owner

bmoers commented Nov 28, 2018

Correct, that's a bug.
I agree with 7e4805e, so it will run() again and use the existing proc to set the worker on pause.
But cant agree with 2b7ce26. Why was socket.emit('paused') added? And the reconnectionAttempts != Infinity will require a worker restart in case the server is down for longer.

@gitlabbin
Copy link
Contributor Author

@bmoers , you are right, I should not include 2b7ce26, which is some code I tried to fix 100% cpu, roll back to previous fix now.

@gitlabbin gitlabbin force-pushed the workernode-running branch 2 times, most recently from 30f07a7 to dafd6a2 Compare November 28, 2018 08:59
	 - only the worker clientState need to be pause
@bmoers
Copy link
Owner

bmoers commented Nov 28, 2018

Thanks.
There is a known bug with Node 11.0.0 nodejs/node#23860

@bmoers bmoers merged commit fb61967 into bmoers:release/3 Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants