Image rotation UI/UX updates #23
Conversation
* rename plugin from "Links Control" to "Orientation" (with deprecation) * align by WCS by default * fix layer letter assignment to ignore wcs-only layers * text/layout tweaks in plugin
* data menu to use radio-buttons instead of badge, preset icons throughout dropdown and data-menu
* less padding * font-size consistent with plugin text * black on yellow for accessibility
github-actions
bot
added
documentation
(icons no longer change so don't need to be tested)
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## wcs-only-layers #23 +/- ##
==================================================
Coverage ? 90.22%
==================================================
Files ? 160
Lines ? 19853
Branches ? 0
==================================================
Hits ? 17912
Misses ? 1941
Partials ? 0 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,186 @@ | |||
| <template> | |||
| <j-tray-plugin | |||
| description="Rotate the viewer orientation or choose to align images by pixels." | |||
There was a problem hiding this comment.
| description="Rotate the viewer orientation or choose to align images by pixels." | |
| description="Rotate the viewer orientation or choose to align images by WCS." |
The phrasing implies WCS is default, and switch to pixel is the functionality. Reverting for this PR (which can be switched again if/when we change to WCS by default in another PR).
There was a problem hiding this comment.
Good point, but I think this should be completely rewritten if we're reverting it for now (since you can't rotate when pixel-linked), sigh.
There was a problem hiding this comment.
how about "... or choose to switch between aligning images by WCS (Sky) or pixels." so then we don't need to remember to change it later?
| @@ -170,7 +170,7 @@ def _get_real_xy(self, image, x, y, reverse=False): | |||
| # we aren't actually guaranteed to get a SkyCoord out, just for images | |||
| # with valid celestial WCS | |||
| try: | |||
| link_type = self.get_link_type(image.label) | |||
| link_type = self.get_link_type(image.label).lower() | |||
There was a problem hiding this comment.
Just a heads up that this snuck in, in case you didn't mean to. But I don't mind.
There was a problem hiding this comment.
I just put this everywhere that there could be ambiguity, whether or not it currently fixes anything.
Description
This pull request:
v-alertstyling for less padding and black on yellow textChange log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.