Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify Orientation angle check (try 2) #28

Closed
wants to merge 1 commit into from
Closed

Simplify Orientation angle check (try 2) #28

wants to merge 1 commit into from

Conversation

pllim
Copy link

@pllim pllim commented Dec 13, 2023 •
edited
Loading

@kecnry, like this?

xref #27

for spacetelescope#2179

@pllim pllim requested a review from bmorris3 as a code owner December 13, 2023 18:33
@github-actions github-actions bot added the imviz label Dec 13, 2023
@kecnry
Copy link

kecnry commented Dec 13, 2023

In theory, but that seems to fail when calling add_orientation manually.

@pllim
Copy link
Author

pllim commented Dec 13, 2023

Gah, okay. At least I tried. Thanks!

@pllim pllim closed this Dec 13, 2023
@pllim pllim deleted the pr-to-brett-pr-simplify-angle branch December 13, 2023 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorris3 bmorris3 Awaiting requested review from bmorris3 bmorris3 is a code owner

Assignees
No one assigned
Labels
imviz
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pllim @kecnry