Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide warning before clicking in dropdown and disable preset/function #30

Closed

Conversation

kecnry
Copy link

@kecnry kecnry commented Jan 24, 2024

This PR is a PR to this PR: spacetelescope#2671

This PR moves the warning stating that choosing "Random" as a colormap overrides the values for stretch function and percentile preset from after making the selection to before via a tooltip in the dropdown itself. This also then disables the inputs for stretch function and percentile preset.

Screen.Recording.2024-01-24.at.3.17.39.PM.mov

Note that this does not technically prevent the user from overriding these values from the API, nor does it result in this warning being raised in advance when setting the colormap to "Random" from the API.

I did not rename "Random" here, but do think that naming it something tied specifically to segmentation maps, and adding that context in the warning itself, would also be useful additions.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (image-segment@ec2b439). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@               Coverage Diff                @@
##             image-segment      #30   +/-   ##
================================================
  Coverage                 ?   90.84%           
================================================
  Files                    ?      162           
  Lines                    ?    20988           
  Branches                 ?        0           
================================================
  Hits                     ?    19067           
  Misses                   ?     1921           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kecnry
Copy link
Author

kecnry commented Feb 22, 2024

closing in favor of a dialog to apply changes implemented in the original PR

@kecnry kecnry closed this Feb 22, 2024
@kecnry kecnry deleted the image-segment-dropdown-info branch February 22, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants