Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] - All test passed #9

Merged
merged 150 commits into from
Dec 9, 2022
Merged

[Test] - All test passed #9

merged 150 commits into from
Dec 9, 2022

Conversation

williamjmorenor
Copy link
Contributor

@williamjmorenor williamjmorenor commented Mar 21, 2022

Con este set de cambios se logra lo siguiente:

  • Funcionalidad del curso avanzada (WIP).
  • Mas de 80% de cobertura de pruebas unitarias.
  • MyPy passed
  • PyLint passed
  • Flake8 passed
  • Bandit passed
  • OCI image build

Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Fixes: #7

Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
pylint now_lms
************* Module now_lms
now_lms/__init__.py:795:8: W0622: Redefining built-in 'id' (redefined-builtin)
now_lms/__init__.py:796:8: W0621: Redefining name 'nuevo_seccion' from outer scope (line 790) (redefined-outer-name)
now_lms/__init__.py:822:8: W0622: Redefining built-in 'id' (redefined-builtin)
now_lms/__init__.py:823:8: W0621: Redefining name 'nuevo_recurso' from outer scope (line 817) (redefined-outer-name)
now_lms/__init__.py:817:31: W0613: Unused argument 'seccion' (unused-argument)

-----------------------------------
Your code has been rated at 9.89/10

Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William Moreno <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
Signed-off-by: William José Moreno Reyes <williamjmorenor@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@williamjmorenor williamjmorenor temporarily deployed to now-lms December 9, 2022 16:23 Inactive
@williamjmorenor williamjmorenor changed the title Feat: [Instructor] - Completa Funcionalidad Curso [Test] - All test passed Dec 9, 2022
@williamjmorenor williamjmorenor merged commit d66ec33 into main Dec 9, 2022
@williamjmorenor williamjmorenor deleted the contenido-curso branch December 9, 2022 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants