Skip to content
This repository has been archived by the owner on Jun 10, 2021. It is now read-only.

Added a group and description to the javadoc and sources jar tasks #6

Merged
merged 2 commits into from
Oct 27, 2013

Conversation

aaronklor
Copy link
Contributor

Added tests for those additions
Updated the readme to reflect the inclusion of these two tasks (rather than hiding their existence)

@bmuschko
Copy link
Owner

Thanks for your pull request. I am going to look over it in more detail tomorrow. I saw the ignored tests. From my experience calling project.evaluate() does not help you work around your issue. It simply doesn't behave a like a real-world Gradle project. This fact causes a lot trouble trying to test code that wraps logic into afterEvaluate.

@aaronklor
Copy link
Contributor Author

That is what I was finding in my research too. Is there a way to accomplish the same task without relying on afterEvaluate? I had manually done that step in an older build script, but I'm not sure where in the lifecycle those parts are evaluated, and therefore I'm not sure if my code implicitly relies on afterEvaluate.

I'd be willing to do some refactoring of configureSigning so those tests can work if you feel it would be beneficial, but I don't want to break any conscious decisions about the operation of the plugin that you've made.

Thanks for looking, this project is quite helpful already and I'm glad to contribute!

@bmuschko bmuschko merged commit e67e94f into bmuschko:master Oct 27, 2013
@bmuschko
Copy link
Owner

Thanks for your contribution. I merged the pull request.

@ghost ghost assigned bmuschko Oct 27, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants