This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
[R4R]libs/db: close batch (#3397) #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClevelDB requires closing when WriteBatch is no longer needed, https://godoc.org/github.com/jmhodges/levigo#WriteBatch.Close Fixes the memory leak in cosmos/cosmos-sdk#3842
unclezoro
changed the title
|
@ackratos @xiangdotli Please note this when test cleveldb |
yutianwu
approved these changes
Mar 27, 2019
ackratos
approved these changes
Mar 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have see one of our seed in site 3 suffer from memory leak problem.
releated to tendermint/tendermint#2821.
And tendermint find use Clevel db will cause memory leak, maybe releated.
cherry-pick from tendermint . tendermint/tendermint#3397
ClevelDB requires closing when WriteBatch is no longer needed, https://godoc.org/github.com/jmhodges/levigo#WriteBatch.Close
Fixes the memory leak in cosmos/cosmos-sdk#3842