Skip to content

Commit

Permalink
fix: nil pointer when filter was deleted (#388)
Browse files Browse the repository at this point in the history
  • Loading branch information
j75689 committed Aug 31, 2021
1 parent c4f9312 commit d1f06d7
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion eth/filters/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,12 @@ func (api *PublicFilterAPI) NewPendingTransactionFilter() rpc.ID {
for {
select {
case ph := <-pendingTxs:
f.hashes = append(f.hashes, ph...)
api.filtersMu.Lock()
f, found := api.filters[pendingTxSub.ID]
if found {
f.hashes = append(f.hashes, ph...)
}
api.filtersMu.Unlock()
case <-pendingTxSub.Err():
api.filtersMu.Lock()
delete(api.filters, pendingTxSub.ID)
Expand Down

0 comments on commit d1f06d7

Please sign in to comment.