Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p: add serve metrics #2114

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

weiihann
Copy link
Contributor

Description

This PR adds P2P serve metrics.

Rationale

It'll be useful to understand why certain serve operations fail.

Example

Some charts:
image
image

Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 69531d6 into bnb-chain:develop Jan 8, 2024
5 checks passed
weiihann added a commit to weiihann/bsc that referenced this pull request Jan 10, 2024
sysvm pushed a commit to sysvm/bsc that referenced this pull request Jan 22, 2024
@zzzckck zzzckck mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants