Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade prysm to support built with go@v1.21 #2128

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Jan 2, 2024

Description

go.mod: upgrade prysm to support built with go@v1.21

Rationale

#1837

  1. use v4.2.0 of prsym, because no tag support v1.21 now

  2. go-ethereum has supported go1.21, we do a cherry-pick for the go-kzg-4844 lib to solve lint error

  3. for lint about updating ECDH lib, we supress them for now
    until go-thereum solve them, we will pick them then.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as draft January 2, 2024 07:05
@buddh0 buddh0 force-pushed the go_1_21 branch 4 times, most recently from 0e46bda to dc31263 Compare January 2, 2024 11:30
@buddh0 buddh0 changed the title go.mod: upgrade prysm to build with go@v1.21 go.mod: upgrade prysm to support built with go@v1.21 Jan 2, 2024
@buddh0
Copy link
Collaborator Author

buddh0 commented Jan 2, 2024

Lint Commit Messages CI fail cause by a cherry-pick , so ignore it

@buddh0
Copy link
Collaborator Author

buddh0 commented Jan 2, 2024

contains a cherry-pick, so don't squash when merge

@buddh0 buddh0 marked this pull request as ready for review January 2, 2024 12:07
zlacfzy
zlacfzy previously approved these changes Jan 3, 2024
@zlacfzy
Copy link
Contributor

zlacfzy commented Jan 3, 2024

the ci is broken.

@buddh0
Copy link
Collaborator Author

buddh0 commented Jan 3, 2024

the ci is broken.

Lint Commit Messages CI fail cause by a cherry-pick , so ignore it

buddh0 and others added 2 commits January 15, 2024 15:37
Changes the trusted_setup to the one created during the kzg-ceremony. The trusted setup file can be found in the consensus specs: https://github.com/ethereum/consensus-specs/blob/dev/presets/mainnet/trusted_setups/trusted_setup_4096.json
---------

Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 0d5ecb5 into bnb-chain:develop Jan 15, 2024
5 of 6 checks passed
@buddh0 buddh0 deleted the go_1_21 branch January 19, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants