Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: optimize parse state scheme in cli and config #2220

Merged
merged 2 commits into from
Feb 20, 2024
Merged

cmd: optimize parse state scheme in cli and config #2220

merged 2 commits into from
Feb 20, 2024

Conversation

sysvm
Copy link
Contributor

@sysvm sysvm commented Feb 19, 2024

Description

Optimize parse state scheme in cli and config.

Rationale

Remove extra parsing StateScheme config param in some functions.

Example

N/A

Changes

Notable changes:

  • N/A

@sysvm sysvm added the r4r ready for review label Feb 20, 2024
RenRick
RenRick approved these changes Feb 20, 2024
View reviewed changes
Copy link

@RenRick RenRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 5378df3 into bnb-chain:develop Feb 20, 2024
6 checks passed
@zzzckck zzzckck mentioned this pull request Feb 20, 2024
Merged
@sysvm sysvm deleted the fix-statescheme branch March 19, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzckck zzzckck zzzckck approved these changes

@RenRick RenRick RenRick approved these changes

@fynnss fynnss fynnss approved these changes

@buddh0 buddh0 buddh0 approved these changes

Assignees
No one assigned
Labels
r4r ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sysvm @buddh0 @fynnss @RenRick @zzzckck