ethclient: fix BlobSidecars api #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzckck
reviewed
Aug 20, 2024
zzzckck
reviewed
Aug 20, 2024
zzzckck
reviewed
Aug 20, 2024
jhgdike
force-pushed
the
dike-fix
branch
2 times, most recently
from
79332cb
to
c5f4362
Compare
galaio
reviewed
Aug 20, 2024
zzzckck
approved these changes
Aug 20, 2024
This was referenced Aug 27, 2024
Merged
Aces42020
reviewed
Sep 3, 2024
| @@ -141,8 +141,8 @@ func (ec *Client) BlobSidecars(ctx context.Context, blockNrOrHash rpc.BlockNumbe | |||
| } | |||
|
|
|||
| // BlobSidecarByTxHash return a sidecar of a given blob transaction | |||
| func (ec *Client) BlobSidecarByTxHash(ctx context.Context, hash common.Hash) (*types.BlobTxSidecar, error) { | |||
| var r *types.BlobTxSidecar | |||
| func (ec *Client) BlobSidecarByTxHash(ctx context.Context, hash common.Hash) (*types.BlobSidecar, error) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the APIs response of BlobSidecars and BlobSidecarByTxHash
Rationale
Recently, I used the APIs above but they didn't work, and I found the response has the wrong structure. So I fixed it.