-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faucet: with mainnet balance check, 0.002BNB at least #2672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzckck
force-pushed
the
faucet_mainnet_balance
branch
2 times, most recently
from
August 29, 2024 03:49
2e6381d
to
4d7449f
Compare
zzzckck
changed the title
faucet: with mainnet balance check
faucet: with mainnet balance check, 0.05BNB at least
Aug 29, 2024
zzzckck
force-pushed
the
faucet_mainnet_balance
branch
from
August 29, 2024 06:19
4d7449f
to
a4e54e5
Compare
zzzckck
force-pushed
the
faucet_mainnet_balance
branch
from
August 29, 2024 06:31
a4e54e5
to
f7ac1a2
Compare
zzzckck
force-pushed
the
faucet_mainnet_balance
branch
from
August 29, 2024 07:05
b56fb51
to
4dba3d6
Compare
zzzckck
changed the title
faucet: with mainnet balance check, 0.05BNB at least
faucet: with mainnet balance check, 0.002BNB at least
Sep 2, 2024
MatusKysel
reviewed
Sep 4, 2024
Co-authored-by: Matus Kysel <MatusKysel@users.noreply.github.com>
zzzckck
force-pushed
the
faucet_mainnet_balance
branch
from
September 4, 2024 07:53
7fda75c
to
5663e52
Compare
MatusKysel
approved these changes
Sep 4, 2024
blxdyx
approved these changes
Sep 4, 2024
zlacfzy
approved these changes
Sep 4, 2024
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In light of the recent surge in tBNB requests, we are considering implementing a mainnet minimum BNB balance check before granting tBNB to prevent abuse.
This practice is quite common in the Ethereum ecosystem, as seen with the Alchemy Ethereum Faucet and the Base Faucet. The proposed minimum balance will be set at 0.002 BNB, which is approximately $1, ensuring it remains affordable for users, such as students.
Rationale
NA
Example
NA
Changes
NA