Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faucet: with mainnet balance check, 0.002BNB at least #2672

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

zzzckck
Copy link
Collaborator

@zzzckck zzzckck commented Aug 28, 2024

Description

In light of the recent surge in tBNB requests, we are considering implementing a mainnet minimum BNB balance check before granting tBNB to prevent abuse.
This practice is quite common in the Ethereum ecosystem, as seen with the Alchemy Ethereum Faucet and the Base Faucet. The proposed minimum balance will be set at 0.002 BNB, which is approximately $1, ensuring it remains affordable for users, such as students.

Rationale

NA

Example

NA

Changes

NA

@zzzckck zzzckck marked this pull request as draft August 28, 2024 22:50
@zzzckck zzzckck force-pushed the faucet_mainnet_balance branch 2 times, most recently from 2e6381d to 4d7449f Compare August 29, 2024 03:49
@zzzckck zzzckck changed the title faucet: with mainnet balance check faucet: with mainnet balance check, 0.05BNB at least Aug 29, 2024
@zzzckck zzzckck force-pushed the faucet_mainnet_balance branch from 4d7449f to a4e54e5 Compare August 29, 2024 06:19
@zzzckck zzzckck force-pushed the faucet_mainnet_balance branch from a4e54e5 to f7ac1a2 Compare August 29, 2024 06:31
@zzzckck zzzckck force-pushed the faucet_mainnet_balance branch from b56fb51 to 4dba3d6 Compare August 29, 2024 07:05
@zzzckck zzzckck changed the title faucet: with mainnet balance check, 0.05BNB at least faucet: with mainnet balance check, 0.002BNB at least Sep 2, 2024
@zzzckck zzzckck marked this pull request as ready for review September 4, 2024 07:39
cmd/faucet/faucet.go Outdated Show resolved Hide resolved
Co-authored-by: Matus Kysel <MatusKysel@users.noreply.github.com>
@zzzckck zzzckck force-pushed the faucet_mainnet_balance branch from 7fda75c to 5663e52 Compare September 4, 2024 07:53
@zzzckck zzzckck merged commit 5c4096f into bnb-chain:develop Sep 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants