eth: Add sidecars when available to broadcasted current block #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
approved these changes
Sep 3, 2024
galaio
approved these changes
Sep 3, 2024
emailtovamos
approved these changes
Sep 3, 2024
zzzckck
approved these changes
Sep 4, 2024
|
thx for your finding. |
graygt
added a commit
to graygt/bsc-geth
that referenced
this pull request
Sep 9, 2024
eth: Add sidecars when available to broadcasted current block (bnb-chain#2675)
This was referenced Sep 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add to the broadcasted "Current" block the Sidecars, when available.
Rationale
The Sidecars were missing in this case, leading to invalid
NewBlockPacketbeing propagated