refactor: remove outdated prune-block tool, implement it by tail-deletion #2809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: remove outdated prune-block tools;
|
validator which has used tool |
NathanBSC
reviewed
Dec 17, 2024
| log.Warn("The node enables PruneAncientData, BlockHistory wille force to 0") | ||
| config.BlockHistory = 0 | ||
| } | ||
| if err = eth.blockchain.PruneBlockHistory(config.BlockHistory); err != nil { |
There was a problem hiding this comment.
run PruneBlockHistory when start nodes?
the prune is not revertable, so I think make user to use it as a tool is better.
when they use this tool, they make their purpose unambiguously
There was a problem hiding this comment.
The node runs as normal in default config(BlockHistory=0), they must set BlockHistory>0 that will trigger the pruning.
|
it would disable the prune-block tool, to avoid impacting the current users, better to be delivered in a separate maintenance release after Pascal hardfork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will remove prune-block tool, it can be replaced by tail-deletion, which is more easy & efficient for managing block history.
This PR could replace
pruneancientfunction in the future.Changes
Notable changes: