-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R4R] add block proccess backoff time when validator is not in turn and received in turn block #426
Merged
+76
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
force-pushed
the
improve_backoff
branch
2 times, most recently
from
September 23, 2021 07:22
58a16b9
to
157c22c
Compare
yutianwu
force-pushed
the
improve_backoff
branch
from
September 23, 2021 08:05
157c22c
to
88ba737
Compare
yutianwu
changed the title
[WIP] add block proccess backoff time when validator is not in turn
[WIP] add block proccess backoff time when validator is not in turn and received in turn block
Sep 23, 2021
unclezoro
reviewed
Sep 26, 2021
unclezoro
reviewed
Sep 26, 2021
unclezoro
reviewed
Sep 26, 2021
unclezoro
reviewed
Sep 26, 2021
unclezoro
reviewed
Sep 27, 2021
unclezoro
reviewed
Sep 27, 2021
unclezoro
changed the title
[WIP] add block proccess backoff time when validator is not in turn and received in turn block
[R4R] add block proccess backoff time when validator is not in turn and received in turn block
Sep 27, 2021
unclezoro
approved these changes
Sep 28, 2021
kyrie-yl
reviewed
Oct 12, 2021
select { | ||
case <-stop: | ||
log.Info("Received block process finished, abort block seal") | ||
return |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think add a blank line between each case will be better for code readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the codebase doesn't add a blank line, that should be fine
kyrie-yl
approved these changes
Oct 12, 2021
j75689
approved these changes
Oct 12, 2021
This was referenced Oct 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the network is congested, the possibility of fork blocks is higher. Sometimes it's because validators not in turn propagate the same height block. The validators not in turn have a backoff time but it may can not process the received in turn block in this duration and propagate the same height block. So we add a mechanism to check if the validator received in turn block and increase the backoff time for the process of the in turn block to finish.
Rationale
To reduce the possibility of fork blocks.
Example
Changes
Notable changes:
Preflight checks
make build
)make test
)Already reviewed by
...
Related issues
... reference related issue #'s here ...