Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]Prefetch state data on mining process #803

Merged
merged 11 commits into from
Mar 28, 2022
Merged

[R4R]Prefetch state data on mining process #803

merged 11 commits into from
Mar 28, 2022

Conversation

qinglin89
Copy link
Contributor

@qinglin89 qinglin89 commented Mar 16, 2022 •
edited
Loading

Description

When miner process mining work, there would be some hard disk access wich are quite time consuming processes.

Rationale

  • Add some prefetch routines to warm up touched data slots by apply transactions concurrently to the given individual state database copy.
    mining-prefetcher-design

Changes

Notable changes:

  • Modify Prefetch inteface so that it would be compatible with mining prefetcher
  • Add PrefetchMining method for state_prefetcher just like Prefetch but a mining version

Performance

The proportion of I/O overhead in mining block cost improvement.(green line represents this version)
811648520509_ pic
The proportion of time delay in mining block process improvement.(green line represents this version)
821648520516_ pic

unclezoro
unclezoro reviewed Mar 20, 2022
View reviewed changes
core/gaspool.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Mar 20, 2022
View reviewed changes
core/state_prefetcher.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Mar 20, 2022
View reviewed changes
miner/worker.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Mar 22, 2022
View reviewed changes
core/state_prefetcher.go Outdated Show resolved Hide resolved
@unclezoro unclezoro changed the title Prefetch state data on mining process [R4R]Prefetch state data on mining process Mar 22, 2022
setunapo
setunapo reviewed Mar 22, 2022
View reviewed changes
core/gaspool.go Outdated Show resolved Hide resolved
setunapo
setunapo reviewed Mar 22, 2022
View reviewed changes
core/state_prefetcher.go Outdated Show resolved Hide resolved
setunapo
setunapo reviewed Mar 22, 2022
View reviewed changes
core/types/transaction.go Outdated Show resolved Hide resolved
setunapo
setunapo reviewed Mar 22, 2022
View reviewed changes
core/state_prefetcher.go Outdated Show resolved Hide resolved
Mercybudda
Mercybudda reviewed Mar 22, 2022
View reviewed changes
miner/worker.go Outdated Show resolved Hide resolved
yutianwu
yutianwu reviewed Mar 24, 2022
View reviewed changes
core/gaspool.go Outdated
@@ -25,6 +25,12 @@ import (
// in a block. The zero value is a pool with zero gas available.
type GasPool uint64

// SetGas set an initial value for gaspool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set -> sets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

setunapo
setunapo reviewed Mar 24, 2022
View reviewed changes
core/gaspool.go Outdated Show resolved Hide resolved
setunapo
setunapo reviewed Mar 25, 2022
View reviewed changes
core/state_prefetcher.go Outdated Show resolved Hide resolved
core/state_prefetcher.go Outdated Show resolved Hide resolved
core/state_prefetcher.go Show resolved Hide resolved
core/types/transaction.go Outdated Show resolved Hide resolved
core/types/transaction.go Outdated Show resolved Hide resolved
yutianwu
yutianwu reviewed Mar 25, 2022
View reviewed changes
core/types/transaction.go Outdated Show resolved Hide resolved
setunapo
setunapo reviewed Mar 25, 2022
View reviewed changes
core/types/transaction.go Outdated Show resolved Hide resolved
unclezoro
unclezoro requested changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do review again after changes

setunapo
setunapo approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@setunapo setunapo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unclezoro unclezoro merged commit cbf433a into bnb-chain:develop Mar 28, 2022
unclezoro pushed a commit that referenced this pull request Mar 29, 2022
@qinglin89 @unclezoro
[R4R]Prefetch state data on mining process (#803)
91d7cd5 
* perf(miner):add mining prefetcher

* fix ineffassign

* fix comments

* fix comments

* fix comments: add AsMessagePrefetch to skip nonce check

* fix comment:refactor check order of method Forward

* fix comments:rename variables

* fix comments: rename

* rename

* fix comments: refactor

* update
This was referenced Apr 8, 2022
Merged
Merged
@qinglin89 qinglin89 mentioned this pull request Jun 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mercybudda Mercybudda Mercybudda left review comments

@yutianwu yutianwu yutianwu left review comments

@setunapo setunapo setunapo approved these changes

@forcodedancing forcodedancing forcodedancing approved these changes

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qinglin89 @yutianwu @unclezoro @Mercybudda @forcodedancing @setunapo