Skip to content

Commit

Permalink
fix: update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
BarryTong65 committed Mar 28, 2024
1 parent c8e9704 commit 923837b
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions client/api_bucket.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ type IBucketClient interface {
GetPaymentAccountFlowRateLimit(ctx context.Context, paymentAddr, bucketOwner sdk.AccAddress, bucketName string) (*storageTypes.QueryPaymentAccountBucketFlowRateLimitResponse, error)
}

// Deprecated: GetCreateBucketApproval - Send create bucket approval request to SP and returns the signature info for the approval of preCreating resources.
// GetCreateBucketApproval - Send create bucket approval request to SP and returns the signature info for the approval of preCreating resources.
//
// - ctx: Context variables for the current API call.
//
Expand Down Expand Up @@ -177,7 +177,13 @@ func (c *Client) CreateBucket(ctx context.Context, bucketName string, primaryAdd

familyID, err := c.QuerySpOptimalGlobalVirtualGroupFamily(ctx, sp.Id, virtualgroupTypes.Strategy_Maximize_Free_Store_Size)
if err != nil {
return "", err
log.Error().Msg(fmt.Sprintf("failed to query sp ptimal vgf: %s", err.Error()))
var signedMsg *storageTypes.MsgCreateBucket
signedMsg, err = c.GetCreateBucketApproval(ctx, createBucketMsg)
if err != nil {
return "", err
}
familyID = signedMsg.PrimarySpApproval.GlobalVirtualGroupFamilyId
}

createBucketMsg.PrimarySpApproval.GlobalVirtualGroupFamilyId = familyID
Expand Down

0 comments on commit 923837b

Please sign in to comment.