feat: add SetBucketFlowRateLimit #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
client/api_bucket.go
Outdated
| // | ||
| // - ret2: Return error if update flow rate limit failed, otherwise return nil. | ||
| func (c *Client) SetBucketFlowRateLimit(ctx context.Context, bucketName string, | ||
| paymentAddr, bucketOwner sdk.AccAddress, flowRateLimit sdkmath.Int, opt types.UpdatePaymentOption, |
There was a problem hiding this comment.
UpdatePaymentOption -> SetBucketFlowRateLimitOption
alexgao001
approved these changes
Mar 20, 2024
client/api_bucket.go
Outdated
| @@ -56,6 +57,8 @@ type IBucketClient interface { | |||
| CancelMigrateBucket(ctx context.Context, bucketName string, opts types.CancelMigrateBucketOptions) (string, error) | |||
| GetBucketMigrationProgress(ctx context.Context, bucketName string, destSP uint32) (types.MigrationProgress, error) | |||
| ListBucketsByPaymentAccount(ctx context.Context, paymentAccount string, opts types.ListBucketsByPaymentAccountOptions) (types.ListBucketsByPaymentAccountResult, error) | |||
| SetBucketFlowRateLimit(ctx context.Context, bucketName string, paymentAddr, bucketOwner sdk.AccAddress, flowRateLimit sdkmath.Int, opt types.UpdatePaymentOption) (string, error) | |||
There was a problem hiding this comment.
UpdatePaymentOption -> SetBucketFlowRateLimitOption
forcodedancing
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will add new messages and queries introduced:
Rationale
Add new messages and queries
Example
n/a
Changes
Notable changes: