feat: add migrate piece auth check #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarryTong65
force-pushed
the
feat-verifyGVG
branch
from
a56b245 to
4e4faaf
Compare
BarryTong65
force-pushed
the
feat-verifyGVG
branch
from
4e4faaf to
8235cd4
Compare
BarryTong65
force-pushed
the
feat-verifyGVG
branch
from
8235cd4 to
0286943
Compare
will-2012
changed the title
will-2012
force-pushed
the
feat-verifyGVG
branch
from
23485b1 to
df8d393
Compare
will-2012
force-pushed
the
feat-verifyGVG
branch
from
df8d393 to
a433366
Compare
BarryTong65
force-pushed
the
feat-verifyGVG
branch
from
3e027fc to
959b693
Compare
will-2012
force-pushed
the
feat-verifyGVG
branch
from
c2339e9 to
d6c96d4
Compare
sysvm
reviewed
Sep 11, 2023
ruojunm
reviewed
Sep 11, 2023
test/e2e/spworkflow/e2e_test.sh
Outdated
| @@ -6,10 +6,10 @@ export CGO_CFLAGS_ALLOW="-O -D__BLST_PORTABLE__" | |||
| workspace=${GITHUB_WORKSPACE} | |||
|
|
|||
| # some constants | |||
| GREENFIELD_REPO_TAG="v0.2.5-alpha.1" | |||
| GREENFIELD_TAG="v0.2.5-alpha.1" | |||
| @@ -139,15 +162,15 @@ func (e *ExecuteModular) doObjectMigration(ctx context.Context, task coretask.Mi | |||
| migratePieceTask := &gfsptask.GfSpMigratePieceTask{ | |||
There was a problem hiding this comment.
if Signature field is never used in GfSpMigratePieceTask, should we consider to remove it?
There was a problem hiding this comment.
Fixed, redundant fields and logic have been removed. The current proto is not used, so incompatible adjustments can be made.
unclezoro
reviewed
Sep 11, 2023
will-2012
force-pushed
the
feat-verifyGVG
branch
4 times, most recently
from
e22f923 to
6f149a5
Compare
will-2012
force-pushed
the
feat-verifyGVG
branch
from
6f149a5 to
edbcb59
Compare
will-2012
force-pushed
the
feat-verifyGVG
branch
from
edbcb59 to
be1829f
Compare
unclezoro
approved these changes
Sep 18, 2023
ruojunm
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add migrate piece auth check.
Rationale
Every migration piece request includes an ECDSA signature which source SP can parse out a destination SP identity information that cannot be forged.The source SP needs to verify whether the destination SP has permission to perform the migration action.
Example
N/A.
Changes
Notable changes: