feat: add detailed logs for special customized logs #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annielz
changed the title
constwz
approved these changes
May 27, 2024
BarryTong65
approved these changes
May 27, 2024
ruojunm
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add detailed logs including bucket_name, obejct_name etc. to 4 kinds of special logs that does not have context.
Rationale
There are 4 special kinds of logs that need to record the detail, therefore had to register the log in gfsperrors at the time of invocation. These logs does not have context come with them, making debug difficult. Additional logs about bucket name and object names can provide more details.
Example
original:
err = ErrConsensusWithDetail("failed to get object info from consensus, error: " + err.Error())
updated:
err = ErrConsensusWithDetail("failed to get object info from consensus, object_name: " +objectInfo.objectName + ", bucket_name: " + objectInfo.bucketName + ", error: " + err.Error())
Changes
Notable changes:
Potential Impacts