feat: code tidy up #155
Merged
feat: code tidy up #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvm
reviewed
Mar 1, 2023
| } | ||
| d, ok := m.objects[key] | ||
| if !ok { | ||
| return nil, errors.EmptyMemoryObject | ||
| return nil, errors.ErrNotExitObject |
There was a problem hiding this comment.
ErrNotExitObject may be ErrNotExistObject?
joeylichang
added a commit
that referenced
this pull request
Mar 4, 2023
* chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code
joeylichang
added a commit
that referenced
this pull request
Mar 4, 2023
chore: change makefile for install gogofaster chore: remove the deprecate code feat:add spdb interface chore: add sp db config feat: add syncer proto chore: change the proto of syncer feat: syncer opt with chain data struct (#154) * feat: syncer opt with chain data struct * feat: change stone node proto by chain * feat: change sync replicate to async * feat:change uploader protoby chain * feat: change proto dir * chore: model dir clean * chorr: util dir clean * chore: test dir clean * chore: fix cr commemts feat: code tidy up (#155) * chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code chore: changeto cli command to manage the app chore: add dump config and list env var cmd refactor: polish gateway module (#157) * refactor: polish gateway module * fix: fix comment tips refactor: implement sp db, remove meta db and job db (#156) * refactor: implement sp db, remove meta db and job dbwq * refactor: implement sp db, remove meta db and job db * fix: fix code to build * fix: fix sql db config error * fix: add sp tables * fix: fix sp errors * chore: add init sp db in service * fix: fix set object info func * fix: fix sp db name * fix: fix sp db error * fix: fix sp db use func name * fix: add detailed comments for each func, struct and interface --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Co-authored-by: joeylichang <joeycli0919@gmail.com> chore: cmd tidy up (#159) fix: uploader and stone node bug chore: update db after success to replicate feat: add command for devops and config log (#162) * feat: add command for DevOps and config log * fix: use until spit func to slit flag * feat: add deployment doc fix: doc format fix: rename variable names for standard (#161) * fix: rename variable names for standard * fix: handle repetitive imported pkgs * fix: define some constants in model --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> feat: sp db adds service config interface (#164) * feat: sp db adds service config interface * fix: add table name * fix: fix get db error --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Main refactor (#166) * chore: add spdb address in env var * fix: stone node replicate idx * refactor: the entry and config * fix: ci lint error fix: deployment doc feat:add config template doc chore: add config template link fix: config template error feat: improve sync piece efficiency (#165) Co-authored-by: joeycli <joeycli0919@gmail.com>
will-2012
pushed a commit
that referenced
this pull request
Mar 5, 2023
chore: change makefile for install gogofaster chore: remove the deprecate code feat:add spdb interface chore: add sp db config feat: add syncer proto chore: change the proto of syncer feat: syncer opt with chain data struct (#154) * feat: syncer opt with chain data struct * feat: change stone node proto by chain * feat: change sync replicate to async * feat:change uploader protoby chain * feat: change proto dir * chore: model dir clean * chorr: util dir clean * chore: test dir clean * chore: fix cr commemts feat: code tidy up (#155) * chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code chore: changeto cli command to manage the app chore: add dump config and list env var cmd refactor: polish gateway module (#157) * refactor: polish gateway module * fix: fix comment tips refactor: implement sp db, remove meta db and job db (#156) * refactor: implement sp db, remove meta db and job dbwq * refactor: implement sp db, remove meta db and job db * fix: fix code to build * fix: fix sql db config error * fix: add sp tables * fix: fix sp errors * chore: add init sp db in service * fix: fix set object info func * fix: fix sp db name * fix: fix sp db error * fix: fix sp db use func name * fix: add detailed comments for each func, struct and interface --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Co-authored-by: joeylichang <joeycli0919@gmail.com> chore: cmd tidy up (#159) fix: uploader and stone node bug chore: update db after success to replicate feat: add command for devops and config log (#162) * feat: add command for DevOps and config log * fix: use until spit func to slit flag * feat: add deployment doc fix: doc format fix: rename variable names for standard (#161) * fix: rename variable names for standard * fix: handle repetitive imported pkgs * fix: define some constants in model --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> feat: sp db adds service config interface (#164) * feat: sp db adds service config interface * fix: add table name * fix: fix get db error --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Main refactor (#166) * chore: add spdb address in env var * fix: stone node replicate idx * refactor: the entry and config * fix: ci lint error fix: deployment doc feat:add config template doc chore: add config template link fix: config template error feat: improve sync piece efficiency (#165) Co-authored-by: joeycli <joeycli0919@gmail.com>
will-2012
pushed a commit
that referenced
this pull request
Mar 5, 2023
chore: change makefile for install gogofaster chore: remove the deprecate code feat:add spdb interface chore: add sp db config feat: add syncer proto chore: change the proto of syncer feat: syncer opt with chain data struct (#154) * feat: syncer opt with chain data struct * feat: change stone node proto by chain * feat: change sync replicate to async * feat:change uploader protoby chain * feat: change proto dir * chore: model dir clean * chorr: util dir clean * chore: test dir clean * chore: fix cr commemts feat: code tidy up (#155) * chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code chore: changeto cli command to manage the app chore: add dump config and list env var cmd refactor: polish gateway module (#157) * refactor: polish gateway module * fix: fix comment tips refactor: implement sp db, remove meta db and job db (#156) * refactor: implement sp db, remove meta db and job dbwq * refactor: implement sp db, remove meta db and job db * fix: fix code to build * fix: fix sql db config error * fix: add sp tables * fix: fix sp errors * chore: add init sp db in service * fix: fix set object info func * fix: fix sp db name * fix: fix sp db error * fix: fix sp db use func name * fix: add detailed comments for each func, struct and interface --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Co-authored-by: joeylichang <joeycli0919@gmail.com> chore: cmd tidy up (#159) fix: uploader and stone node bug chore: update db after success to replicate feat: add command for devops and config log (#162) * feat: add command for DevOps and config log * fix: use until spit func to slit flag * feat: add deployment doc fix: doc format fix: rename variable names for standard (#161) * fix: rename variable names for standard * fix: handle repetitive imported pkgs * fix: define some constants in model --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> feat: sp db adds service config interface (#164) * feat: sp db adds service config interface * fix: add table name * fix: fix get db error --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Main refactor (#166) * chore: add spdb address in env var * fix: stone node replicate idx * refactor: the entry and config * fix: ci lint error fix: deployment doc feat:add config template doc chore: add config template link fix: config template error feat: improve sync piece efficiency (#165) Co-authored-by: joeycli <joeycli0919@gmail.com>
will-2012
pushed a commit
that referenced
this pull request
Mar 5, 2023
chore: change makefile for install gogofaster chore: remove the deprecate code feat:add spdb interface chore: add sp db config feat: add syncer proto chore: change the proto of syncer feat: syncer opt with chain data struct (#154) * feat: syncer opt with chain data struct * feat: change stone node proto by chain * feat: change sync replicate to async * feat:change uploader protoby chain * feat: change proto dir * chore: model dir clean * chorr: util dir clean * chore: test dir clean * chore: fix cr commemts feat: code tidy up (#155) * chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code chore: changeto cli command to manage the app chore: add dump config and list env var cmd refactor: polish gateway module (#157) * refactor: polish gateway module * fix: fix comment tips refactor: implement sp db, remove meta db and job db (#156) * refactor: implement sp db, remove meta db and job dbwq * refactor: implement sp db, remove meta db and job db * fix: fix code to build * fix: fix sql db config error * fix: add sp tables * fix: fix sp errors * chore: add init sp db in service * fix: fix set object info func * fix: fix sp db name * fix: fix sp db error * fix: fix sp db use func name * fix: add detailed comments for each func, struct and interface --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Co-authored-by: joeylichang <joeycli0919@gmail.com> chore: cmd tidy up (#159) fix: uploader and stone node bug chore: update db after success to replicate feat: add command for devops and config log (#162) * feat: add command for DevOps and config log * fix: use until spit func to slit flag * feat: add deployment doc fix: doc format fix: rename variable names for standard (#161) * fix: rename variable names for standard * fix: handle repetitive imported pkgs * fix: define some constants in model --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> feat: sp db adds service config interface (#164) * feat: sp db adds service config interface * fix: add table name * fix: fix get db error --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Main refactor (#166) * chore: add spdb address in env var * fix: stone node replicate idx * refactor: the entry and config * fix: ci lint error fix: deployment doc feat:add config template doc chore: add config template link fix: config template error feat: improve sync piece efficiency (#165) Co-authored-by: joeycli <joeycli0919@gmail.com>
will-2012
pushed a commit
that referenced
this pull request
Mar 5, 2023
chore: change makefile for install gogofaster chore: remove the deprecate code feat:add spdb interface chore: add sp db config feat: add syncer proto chore: change the proto of syncer feat: syncer opt with chain data struct (#154) * feat: syncer opt with chain data struct * feat: change stone node proto by chain * feat: change sync replicate to async * feat:change uploader protoby chain * feat: change proto dir * chore: model dir clean * chorr: util dir clean * chore: test dir clean * chore: fix cr commemts feat: code tidy up (#155) * chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code chore: changeto cli command to manage the app chore: add dump config and list env var cmd refactor: polish gateway module (#157) * refactor: polish gateway module * fix: fix comment tips refactor: implement sp db, remove meta db and job db (#156) * refactor: implement sp db, remove meta db and job dbwq * refactor: implement sp db, remove meta db and job db * fix: fix code to build * fix: fix sql db config error * fix: add sp tables * fix: fix sp errors * chore: add init sp db in service * fix: fix set object info func * fix: fix sp db name * fix: fix sp db error * fix: fix sp db use func name * fix: add detailed comments for each func, struct and interface --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Co-authored-by: joeylichang <joeycli0919@gmail.com> chore: cmd tidy up (#159) fix: uploader and stone node bug chore: update db after success to replicate feat: add command for devops and config log (#162) * feat: add command for DevOps and config log * fix: use until spit func to slit flag * feat: add deployment doc fix: doc format fix: rename variable names for standard (#161) * fix: rename variable names for standard * fix: handle repetitive imported pkgs * fix: define some constants in model --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> feat: sp db adds service config interface (#164) * feat: sp db adds service config interface * fix: add table name * fix: fix get db error --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Main refactor (#166) * chore: add spdb address in env var * fix: stone node replicate idx * refactor: the entry and config * fix: ci lint error fix: deployment doc feat:add config template doc chore: add config template link fix: config template error feat: improve sync piece efficiency (#165) Co-authored-by: joeycli <joeycli0919@gmail.com>
will-2012
pushed a commit
that referenced
this pull request
Mar 6, 2023
chore: change makefile for install gogofaster chore: remove the deprecate code feat:add spdb interface chore: add sp db config feat: add syncer proto chore: change the proto of syncer feat: syncer opt with chain data struct (#154) * feat: syncer opt with chain data struct * feat: change stone node proto by chain * feat: change sync replicate to async * feat:change uploader protoby chain * feat: change proto dir * chore: model dir clean * chorr: util dir clean * chore: test dir clean * chore: fix cr commemts feat: code tidy up (#155) * chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code chore: changeto cli command to manage the app chore: add dump config and list env var cmd refactor: polish gateway module (#157) * refactor: polish gateway module * fix: fix comment tips refactor: implement sp db, remove meta db and job db (#156) * refactor: implement sp db, remove meta db and job dbwq * refactor: implement sp db, remove meta db and job db * fix: fix code to build * fix: fix sql db config error * fix: add sp tables * fix: fix sp errors * chore: add init sp db in service * fix: fix set object info func * fix: fix sp db name * fix: fix sp db error * fix: fix sp db use func name * fix: add detailed comments for each func, struct and interface --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Co-authored-by: joeylichang <joeycli0919@gmail.com> chore: cmd tidy up (#159) fix: uploader and stone node bug chore: update db after success to replicate feat: add command for devops and config log (#162) * feat: add command for DevOps and config log * fix: use until spit func to slit flag * feat: add deployment doc fix: doc format fix: rename variable names for standard (#161) * fix: rename variable names for standard * fix: handle repetitive imported pkgs * fix: define some constants in model --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> feat: sp db adds service config interface (#164) * feat: sp db adds service config interface * fix: add table name * fix: fix get db error --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Main refactor (#166) * chore: add spdb address in env var * fix: stone node replicate idx * refactor: the entry and config * fix: ci lint error fix: deployment doc feat:add config template doc chore: add config template link fix: config template error feat: improve sync piece efficiency (#165) Co-authored-by: joeycli <joeycli0919@gmail.com>
will-2012
pushed a commit
that referenced
this pull request
Mar 6, 2023
chore: change makefile for install gogofaster chore: remove the deprecate code feat:add spdb interface chore: add sp db config feat: add syncer proto chore: change the proto of syncer feat: syncer opt with chain data struct (#154) * feat: syncer opt with chain data struct * feat: change stone node proto by chain * feat: change sync replicate to async * feat:change uploader protoby chain * feat: change proto dir * chore: model dir clean * chorr: util dir clean * chore: test dir clean * chore: fix cr commemts feat: code tidy up (#155) * chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code chore: changeto cli command to manage the app chore: add dump config and list env var cmd refactor: polish gateway module (#157) * refactor: polish gateway module * fix: fix comment tips refactor: implement sp db, remove meta db and job db (#156) * refactor: implement sp db, remove meta db and job dbwq * refactor: implement sp db, remove meta db and job db * fix: fix code to build * fix: fix sql db config error * fix: add sp tables * fix: fix sp errors * chore: add init sp db in service * fix: fix set object info func * fix: fix sp db name * fix: fix sp db error * fix: fix sp db use func name * fix: add detailed comments for each func, struct and interface --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Co-authored-by: joeylichang <joeycli0919@gmail.com> chore: cmd tidy up (#159) fix: uploader and stone node bug chore: update db after success to replicate feat: add command for devops and config log (#162) * feat: add command for DevOps and config log * fix: use until spit func to slit flag * feat: add deployment doc fix: doc format fix: rename variable names for standard (#161) * fix: rename variable names for standard * fix: handle repetitive imported pkgs * fix: define some constants in model --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> feat: sp db adds service config interface (#164) * feat: sp db adds service config interface * fix: add table name * fix: fix get db error --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Main refactor (#166) * chore: add spdb address in env var * fix: stone node replicate idx * refactor: the entry and config * fix: ci lint error fix: deployment doc feat:add config template doc chore: add config template link fix: config template error feat: improve sync piece efficiency (#165) Co-authored-by: joeycli <joeycli0919@gmail.com>
will-2012
pushed a commit
that referenced
this pull request
Mar 6, 2023
chore: change makefile for install gogofaster chore: remove the deprecate code feat:add spdb interface chore: add sp db config feat: add syncer proto chore: change the proto of syncer feat: syncer opt with chain data struct (#154) * feat: syncer opt with chain data struct * feat: change stone node proto by chain * feat: change sync replicate to async * feat:change uploader protoby chain * feat: change proto dir * chore: model dir clean * chorr: util dir clean * chore: test dir clean * chore: fix cr commemts feat: code tidy up (#155) * chore:model and config comments and variable name tidying up * chore: tidy up pky code * chore: proto tidy up * chore:change UnSupported to unsupport * chore: tidy up service code chore: changeto cli command to manage the app chore: add dump config and list env var cmd refactor: polish gateway module (#157) * refactor: polish gateway module * fix: fix comment tips refactor: implement sp db, remove meta db and job db (#156) * refactor: implement sp db, remove meta db and job dbwq * refactor: implement sp db, remove meta db and job db * fix: fix code to build * fix: fix sql db config error * fix: add sp tables * fix: fix sp errors * chore: add init sp db in service * fix: fix set object info func * fix: fix sp db name * fix: fix sp db error * fix: fix sp db use func name * fix: add detailed comments for each func, struct and interface --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Co-authored-by: joeylichang <joeycli0919@gmail.com> chore: cmd tidy up (#159) fix: uploader and stone node bug chore: update db after success to replicate feat: add command for devops and config log (#162) * feat: add command for DevOps and config log * fix: use until spit func to slit flag * feat: add deployment doc fix: doc format fix: rename variable names for standard (#161) * fix: rename variable names for standard * fix: handle repetitive imported pkgs * fix: define some constants in model --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> feat: sp db adds service config interface (#164) * feat: sp db adds service config interface * fix: add table name * fix: fix get db error --------- Co-authored-by: DylanYong <dylan.y@nodereal.io> Main refactor (#166) * chore: add spdb address in env var * fix: stone node replicate idx * refactor: the entry and config * fix: ci lint error fix: deployment doc feat:add config template doc chore: add config template link fix: config template error feat: improve sync piece efficiency (#165) Co-authored-by: joeycli <joeycli0919@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: