Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix verify permission bug #225

Merged
merged 1 commit into from
Mar 20, 2023
Merged

fix: fix verify permission bug #225

merged 1 commit into from
Mar 20, 2023

Conversation

will-2012
Copy link
Collaborator

@will-2012 will-2012 commented Mar 20, 2023 •
edited
Loading

Description

Fix verify get-object permission bug and add verify put-object permission.

Rationale

Verify permission by the greenfield chain permission module.

Example

N/A

Changes

Notable changes:

  • Gateway checks authorization.
  • Update the greenfield chain version.

@will-2012 will-2012 force-pushed the fix-verifypermission branch 4 times, most recently from e7a1fb7 to ea5d396 Compare March 20, 2023 11:49
@will-2012 will-2012 added the wip Working in process label Mar 20, 2023
@will-2012 will-2012 force-pushed the fix-verifypermission branch from ea5d396 to 392a54e Compare March 20, 2023 12:14
@joeylichang joeylichang merged commit 3291084 into develop Mar 20, 2023
@will-2012 will-2012 added r4r Ready for review and removed wip Working in process labels Mar 20, 2023
@joeylichang joeylichang deleted the fix-verifypermission branch March 20, 2023 12:33
joeylichang added a commit that referenced this pull request Mar 20, 2023
@will-2012 @joeylichang
@BarryTong65 @sysvm @yzhaoyu @krish-nr @constwz @j75689
feat: merge develop to master (#226)
9709bc8 
* chore: add notes for sp  (#193)

* chore: add notes for sql db

* fix: cmd dir notes

* chore: mode dir note tidy

* chore: pkg dir note tidy

* chore: service dir note tidy

* fix: cr comments

* fix: the store notes

* refactor: refactor metadata service (#188)

* fix: bypass v2 auth for test (#152) (#153)

* feat: update grpc metadata getway (#151)

* feat: update grpc metadata gateway

* fix: buf-lint

* fix: remove store

* feat: load metadata service db config from ENV

* feat: storage provider refactor (#168)

chore: change makefile for install gogofaster

chore: remove the deprecate code

feat:add spdb interface

chore: add sp db config

feat: add syncer proto

chore: change the proto of syncer

feat: syncer refactor with chain data struct (#154)

feat: change stone node proto by chain

* feat: change sync replicate to async

* feat: change proto dir

feat: change uploader proto by chain

chore: tidy up code by dir

* chore: model dir clean

* chore: util dir clean

* chore: test dir clean

* chore: fix cr commemts

* chore:model and config comments and variable name tidying up

* chore: tidy up pky code

* chore: proto tidy up

* chore:change UnSupported to unsupport

* chore: tidy up service code

feat: changeto cli command to manage the app

chore: add dump config and list env var cmd

refactor: polish gateway module (#157)

* refactor: polish gateway module

* fix: fix comment tips

refactor: implement sp db, remove meta db and job db (#156)

* refactor: implement sp db, remove meta db and job dbwq

* refactor: implement sp db, remove meta db and job db

* feat: add sp tables

* fix: fix sp errors

* chore: add init sp db in service

* fix: fix sp db use func name

* fix: add detailed comments for each func, struct and interface

---------




chore: cmd tidy up (#159)

fix: uploader and stone node bug

chore: update db after success to replicate

feat: add command for devops and config log (#162)

* feat: add command for DevOps and config log

* fix: use until spit func to slit flag

* feat: add deployment doc

fix: doc format

fix: rename variable names for standard (#161)

* fix: rename variable names for standard

* fix: handle repetitive imported pkg dir

* fix: define some constants in model dir

---------



feat: sp db adds service config interface (#164)

* feat: sp db adds service config interface

* feat: add table name


---------



Main refactor (#166)

* chore: add spdb address in env var

* fix: stone node replicate idx

* refactor: the entry and config

* fix: ci lint error

fix: deployment doc

feat:add config template doc

chore: add config template link

fix: config template error

feat: improve sync piece efficiency (#165)

Co-authored-by: joeylichang <joeycli0919@gmail.com>

* fix: refactor metadata (#170)

* fix: refactor metadata according to the new commit

* fix: recover default config and change http address to grpc

* fix: remove MetadataCfg and refactor log

* fix: check if metadata is nil and add error response

* fix: remove status code

* feat: piece store adds minio storage type (#169)

* feat: piece store adds minio storage type

* test: add minio and sharding e2e test

---------

Co-authored-by: DylanYong <dylan.y@nodereal.io>

* feat: implement manager module (#172)

* feat: implement manager module

* fix: polish by comment tips

* feat: add localup script (#171)

* feat: add localup script

* fix: polish by comment tips

* doc: add link to doc (#180)

* fix: add links to deployment and setup local docs

* ci: add branch naming rules (#179)

* ci: add branch naming rules

---------

Co-authored-by: DylanYong <dylan.y@nodereal.io>

* docs: add change log for release v0.0.3 (#182)

* doc: add changelog for release v0.0.3

* fix: PR links

* refactor: refactor metadata service

* fix: remove atomic.Bool

* fix: rebase develop branch

* fix: fix all member variables

* fix: fix named return values

* fix: update comments

* fix: update metadata proto

* fix: update comments

---------

Co-authored-by: will-2012 <117156346+will-2012@users.noreply.github.com>
Co-authored-by: joeylichang <joeycli0919@gmail.com>
Co-authored-by: VM <112189277+sysvm@users.noreply.github.com>
Co-authored-by: DylanYong <dylan.y@nodereal.io>

* docs: add sp docs (#196)

docs: add workflow docs (#192)

* refactor: rename stonenode, syncer to tasknode, recevier (#197)

* refactor: rename stonenode,syncer to tasknode,recevier

* fix: update comment tips

* fix: update by comment tips

* fix: polish by comment tips

* docs: refining readme (#200)

* refining readme

* build: replace go1.19 with go1.18 (#198)

* build: replace go1.19 with go1.18

---------

Co-authored-by: DylanYong <dylan.y@nodereal.io>

* feat: add endpoint for service

* feat: chang config template dir for renewed on time

* docs: add block syncer config (#208)

* docs: add block syncer config

* fix: add blocksyncer service to list

* fix: add blocksyncer to config template

* feat: update get bucket apis (#202)

* feat: update metadata apis

feat: update metadata apis

feat: update check_sums [][]bytes

feat: update metadata

fix: update ci workflows

fix: update ci workflows

fix: grpc zero value

feat: imple getUserBucketsCount

feat: update ci workflows

fix: listObjectsByBucketRouterName router path

feat: use s3 styles for apis

unblock env

* fix: update deleted object api

* fix: delete metadata workflows

* refactor: refactor all the comments and styles

* fix: fix bucket api

* fix: rename service and fix comments

* refactor: impl bsdb for metadata

* refactor: impl bsdb for metadata

* fix: fix comments

* fix: update image tag

* refactor: refactor db schema

* fix: remove metadata ci workflow

* fix: db response style (#209)

* fix: change to make build in readme

* fix: potential attack risks in on-chain storage module (#215)

* fix: add annotation in singer.proto

* fix: refine signer config

* fix: IntegrityHash signature format

* chore: upgrade github.com/bnb-chain/greenfield

* fix: comments from sysvm

* feat: support query quota and list read record (#206)

* feat: add query traffic interface

* feat: use chain verify permission api

* chore: polish by comment tips

* docs: add changelog for releasing v0.0.4

* fix: import pkg order

* fix: import pkg error

* fix: increase the data size sent and received by gRPC (#222)

* build: change greenfield version to v0.0.9 (#223)

* build: chang greenfield version to v0.0.9

* fix: build dependency error

* fix: fix verify permission bug (#225)

---------

Co-authored-by: joeycli <joeycli0919@gmail.com>
Co-authored-by: BarryTong65 <122767193+BarryTong65@users.noreply.github.com>
Co-authored-by: VM <112189277+sysvm@users.noreply.github.com>
Co-authored-by: DylanYong <dylan.y@nodereal.io>
Co-authored-by: krish-nr <krish.z@nodereal.io>
Co-authored-by: krish-z <122767080+krish-nr@users.noreply.github.com>
Co-authored-by: constwz <122766871+constwz@users.noreply.github.com>
Co-authored-by: dylanhuang <j75689@gmail.com>
will-2012 added a commit that referenced this pull request Mar 27, 2023
@will-2012 @joeylichang
@BarryTong65 @sysvm @yzhaoyu @krish-nr @constwz @j75689
feat: merge develop to master for v0.0.5 (#251)
6eeb9d3 
* fix: fix verify permission bug (#225)

* feat: merge release v0.0.4 fix to develop (#230)

* fix: fix route bug

* build: change signer wiltlist ip

* fix: fix https sync failed

* fix: router getUserBucketsRouterName path (#229)

* fix: router getUserBucketsRouterName path and update router comments

Co-authored-by: BarryTong65 <122767193+BarryTong65@users.noreply.github.com>
Co-authored-by: will-2012 <will.w@nodereal.io>

* ci: add gosec action (#231)

* feat: implement p2p protocol and rpc service (#221)

* feat: implement p2p protocol node and RPC service

* feat: p2p RPC server

* fix: config port conflict

* feat: get secondary SP approval from p2p server

* feat: verify approval in gateway

* fix: golang ci lint error

* fix: integration testing bugs

* feat: load p2p private key from ENV var

* feat: implement p2p protocol msg sign and verify

* feat: p2p protocol msg sign in signer service

* feat: signer client method for sign p2p protocol msg

* feat: signature verify in related modules

* fix: manager grace stop

* fix: object Id proto clone to deep copy panic

* feat: p2p create key pairs command

* feat: p2p config to local up script

* fix: local up script deploy p2p error

* fix: pr comments

* fix: change p2p config name for following the project specification

* chore: refine error code

* feat: sp services add metrics (#211)

* feat: sp service adds metrics

* fix: add metrics config

* refactor: refactor metrics service

* fix: update go.mod

* fix: fix config toml template

* chore: coding adjustments

* fix: golang ci lint error

---------

Co-authored-by: DylanYong <dylan.y@nodereal.io>
Co-authored-by: joeylichang <joeycli0919@gmail.com>

* feat: implement metadata payment apis (#235)

* feat: implement metadata payment apis

fix: update commnets and db schema

fix: update OutFlows type json

fix: update metadata

* fix: add the errDesciption and fix requestID

* fix: fix Id & CheckSums

* feat: update bucket id (#241)

* feat: metadata schema update

fix: update config

* fix: update SettleTimestamp and format imports

* fix: fix owner and end_block_number

* fix: adjust check condition to avoid panic (#243)

Co-authored-by: DylanYong <dylan.y@nodereal.io>

* feat: update the juno version (#244)

* feat: resource manager (#246)

* feat: resouce manager

* feat: add resource manager flags

* feat: add resource manager to dowmloader service

* feat: add resource manager to challenge service

* feat: add resource manager to task node service

* chore: rich log info for rcmgr

* feat: init global resource manager

* fix: integration testing bugs

* feat: return preparations error to client during put object

* chore: fix cr comments

* docs: release changlog for v0.0.5 (#249)

* docs: release changlog for v0.0.5

* build: update the greenfield chain version (#248)

* build: update the greenfield chain version

* feat:update juno version

* fix: update metadata for chain v0.0.10

fix: update metadata for chain v0.0.10

fix: update comments for bsdb schema

* fix: update from OneRowId to OneRowID

---------

Co-authored-by: constwz <changbohao30@gmail.com>
Co-authored-by: BarryTong65 <barrytong.work@gmail.com>

---------

Co-authored-by: joeycli <joeycli0919@gmail.com>
Co-authored-by: BarryTong65 <122767193+BarryTong65@users.noreply.github.com>
Co-authored-by: VM <112189277+sysvm@users.noreply.github.com>
Co-authored-by: DylanYong <dylan.y@nodereal.io>
Co-authored-by: krish-nr <krish.z@nodereal.io>
Co-authored-by: krish-z <122767080+krish-nr@users.noreply.github.com>
Co-authored-by: constwz <122766871+constwz@users.noreply.github.com>
Co-authored-by: dylanhuang <j75689@gmail.com>
Co-authored-by: constwz <changbohao30@gmail.com>
Co-authored-by: BarryTong65 <barrytong.work@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
r4r Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@will-2012 @joeylichang